ci: re-enable phpdoc

Author: matthewhilton

.github/workflows/ci.yml

@@ -9,4 +9,3 @@ jobs:
     with:
       extra_plugin_runners: 'moodle-plugin-ci add-plugin --branch MOODLE_405_STABLE catalyst/moodle-local_smartmedia'
       disable_phpcpd: true
-      disable_phpdoc: true

download_metadata.php

@@ -14,11 +14,6 @@
 // You should have received a copy of the GNU General Public License
 // along with Moodle.  If not, see <http://www.gnu.org/licenses/>.
 
-use core\url;
-use local_smartmedia\aws_api;
-use local_smartmedia\aws_elastic_transcoder;
-use local_smartmedia\conversion;
-
 /**
  *  Smart media metadata download portal.
  *
@@ -27,6 +22,11 @@
  * @license    http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
  */
 
+use core\url;
+use local_smartmedia\aws_api;
+use local_smartmedia\aws_elastic_transcoder;
+use local_smartmedia\conversion;
+
 require_once(__DIR__ . '/../../config.php');
 require_admin();
 confirm_sesskey();

filter.php

@@ -124,6 +124,7 @@ class filter_smartmedia extends moodle_text_filter {
      *
      * @param context $context The current context.
      * @param array $localconfig Any context-specific configuration for this filter.
+     * @param conversion|null $conversion
      */
     public function __construct($context, array $localconfig, conversion $conversion = null) {
         parent::__construct($context, $localconfig);
@@ -370,7 +371,8 @@ private function get_placeholder_markup(string $linkhref, string $fulltext): str
      * Given a matched link check if there is smartmedia available,
      * and return updated link if there is.
      *
-     * @param array $matches An array of link matches.
+     * @param string $target
+     * @param string $fulltext
      * @return array Array of newtext and whether the text was replaced
      */
     private function replace($target, $fulltext): array {

tests/filter_test.php

@@ -466,6 +466,13 @@ public function test_filter_replace_dataprovider() {
     }
 
     /**
+     * Test filter replacement
+     * @param string $text
+     * @param string $regex
+     * @param int $matchcount
+     * @param int $mediaplugincount
+     * @param string $pageurl
+     * @param string $contextkey
      * @dataProvider test_filter_replace_dataprovider
      */
     public function test_filter_replace($text, $regex, $matchcount, $mediaplugincount, $pageurl, $contextkey): void {