Fix phpdoc errors

Author: TomoTsuyuki

classes/helper.php

@@ -252,18 +252,18 @@ public static function send_email($courseid) {
     /**
      * Count broken links
      *
-     * @param $courseid
+     * @param int $courseid
      * @throws \dml_exception
      */
-    public static function count_broken_links($courseid) {
+    public static function count_broken_links(int $courseid) {
         global $DB;
         $sql = "SELECT count(1) AS count
                   FROM {tool_crawler_url}  b
              LEFT JOIN {tool_crawler_edge} l ON l.b = b.id
              LEFT JOIN {tool_crawler_url}  a ON l.a = a.id
              LEFT JOIN {course} c ON c.id = a.courseid
-                 WHERE b.httpcode != '200' AND c.id = $courseid";
-        return $DB->count_records_sql($sql);
+                 WHERE b.httpcode != '200' AND c.id = :courseid";
+        return $DB->count_records_sql($sql, ['courseid'=> $courseid]);
     }
 
 }

classes/table/course_links.php

@@ -30,19 +30,22 @@
 use tool_crawler\helper;
 use moodle_url;
 use html_writer;
+use stdClass;
 
 class course_links extends table_sql implements renderable {
 
     private $courseid;
+
+    private $page;
     /**
      * table constructor.
      *
-     * @param $uniqueid table unique id
+     * @param string $uniqueid table unique id
      * @param \moodle_url $url base url
+     * @param int $courseid course id
      * @param int $page current page
      * @param int $perpage number of records per page
      * @throws \coding_exception
-     * @throws \coding_exception
      */
     public function __construct($uniqueid, \moodle_url $url, $courseid, $page = 0, $perpage = 20) {
         parent::__construct($uniqueid);
@@ -165,30 +168,30 @@ public function query_db($pagesize, $useinitialsbar = true) {
 
     /**
      *
-     * @param $row
+     * @param stdClass $row
      * @return string
      */
-    protected function col_lastcrawledtime($row) {
+    protected function col_lastcrawledtime(stdClass $row) {
         return userdate($row->lastcrawled);
     }
 
     /**
      *
-     * @param $row
-     * @return string
+     * @param stdClass $row
+     * @return stdClass $row
      * @throws \coding_exception
      */
-    protected function col_priority($row) {
+    protected function col_priority(stdClass $row) {
         return tool_crawler_priority_level($row->priority);
     }
 
     /**
      *
-     * @param $row
+     * @param stdClass $row
      * @return mixed
      * @throws \coding_exception
      */
-    protected function col_httpcode($row) {
+    protected function col_httpcode(stdClass $row) {
         $text = tool_crawler_http_code($row);
         if ($translation = \tool_crawler\helper::translate_httpcode($row->httpcode)) {
             $text .= "<br/>" . $translation;
@@ -198,11 +201,11 @@ protected function col_httpcode($row) {
 
     /**
      *
-     * @param $row
+     * @param stdClass $row
      * @return mixed
      * @throws \coding_exception
      */
-    protected function col_target($row) {
+    protected function col_target(stdClass $row) {
         $text = trim($row->text);
         if ($text == "") {
             $text = get_string('missing', 'tool_crawler');
@@ -216,11 +219,11 @@ protected function col_target($row) {
 
     /**
      *
-     * @param $row
+     * @param stdClass $row
      * @return mixed
      * @throws \coding_exception
      */
-    protected function col_url($row) {
+    protected function col_url(stdClass $row) {
         return tool_crawler_link($row->url, $row->title, $row->redirect, false, $this->courseid);
     }
 

locallib.php

@@ -42,6 +42,7 @@
  * @param string $redirect The final URL if a redirect was served.
  * @param string $labelishtml Whether the $label parameter contains an HTML snippet (if true) or plain text (if false). Defaults to
  *               plain text.
+ * @param int $courseid course id
  * @return string HTML snippet which can be used in output.
  */
 function tool_crawler_link($url, $label, $redirect = '', $labelishtml = false, $courseid = 0) {
@@ -241,6 +242,7 @@ function tool_crawler_url_gen_table($data) {
  * Generates and returns a full HTML page with details about a URL.
  *
  * @param string $url The URL.
+ * @param int $courseid course id
  * @return string A HTML page about the URL.
  */
 function tool_crawler_url_create_page($url, $courseid = 0) {

renderer.php

@@ -29,7 +29,7 @@ class tool_crawler_renderer extends plugin_renderer_base {
 
     /**
      * Render table.
-     * @param dismissed_notice $table dismissed notice table
+     * @param course_links $table course_links table
      * @return false|string
      */
     public function render_course_links(course_links $table) {