Skip to content

Commit b9b7f3f

Browse files
authored
feat: changes to footer links (#898)
1 parent 1e827b8 commit b9b7f3f

File tree

4 files changed

+33
-10
lines changed

4 files changed

+33
-10
lines changed

packages/vue/tests/e2e/app.spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ test('Page has loaded and rendered', async ({ page }) => {
1616

1717
// Footer has rendered
1818
const footerLinks = await page.locator('gcds-footer a').count();
19-
await expect(footerLinks).toBe(26);
19+
await expect(footerLinks).toBe(27);
2020
});
2121

2222
test('Select component event handling', async ({ page }) => {

packages/web/src/components/gcds-footer/gcds-footer.css

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@
6969
}
7070

7171
h3 {
72-
font: var( --gcds-footer-font-heading);
72+
font: var(--gcds-footer-font-heading);
7373
margin: var(--gcds-footer-heading-margin);
7474
}
7575

@@ -113,7 +113,7 @@
113113

114114
&.main__themenav .themenav__list {
115115
display: grid;
116-
grid-template-rows: repeat(18, 1fr);
116+
grid-template-rows: repeat(19, 1fr);
117117
grid-auto-flow: column;
118118
}
119119
}
@@ -194,7 +194,7 @@
194194
}
195195

196196
nav.main__themenav .themenav__list {
197-
grid-template-rows: repeat(9, 1fr);
197+
grid-template-rows: repeat(10, 1fr);
198198
}
199199
}
200200
}
@@ -224,7 +224,7 @@
224224
}
225225

226226
nav.main__themenav .themenav__list {
227-
grid-template-rows: repeat(6, 1fr);
227+
grid-template-rows: repeat(7, 1fr);
228228
}
229229
}
230230
}

packages/web/src/components/gcds-footer/i18n/i18n.js

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ const I18N = {
7373
link: 'https://international.gc.ca/world-monde/index.aspx?lang=eng',
7474
},
7575
finance: {
76-
text: 'Money and finance',
76+
text: 'Money and finances',
7777
link: 'https://www.canada.ca/en/services/finance.html',
7878
},
7979
science: {
@@ -92,6 +92,10 @@ const I18N = {
9292
text: 'Youth',
9393
link: 'https://www.canada.ca/en/services/youth.html',
9494
},
95+
life: {
96+
text: 'Manage life events',
97+
link: 'https://www.canada.ca/en/services/life-events.html',
98+
},
9599
},
96100
},
97101
site: {
@@ -196,7 +200,7 @@ const I18N = {
196200
link: 'https://www.international.gc.ca/world-monde/index.aspx?lang=fra',
197201
},
198202
finance: {
199-
text: 'Argent et finance',
203+
text: 'Argent et finances',
200204
link: 'https://www.canada.ca/fr/services/finance.html',
201205
},
202206
science: {
@@ -215,6 +219,10 @@ const I18N = {
215219
text: 'Jeunesse',
216220
link: 'https://www.canada.ca/fr/services/jeunesse.html',
217221
},
222+
life: {
223+
text: 'Gérer les événements de la vie',
224+
link: 'https://www.canada.ca/fr/services/evenements-vie.html',
225+
},
218226
},
219227
},
220228
site: {

packages/web/src/components/gcds-footer/test/gcds-footer.spec.tsx

Lines changed: 18 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -160,7 +160,7 @@ describe('gcds-footer', () => {
160160
</li>
161161
<li>
162162
<gcds-link size="small" href="https://www.canada.ca/en/services/finance.html">
163-
Money and finance
163+
Money and finances
164164
</gcds-link>
165165
</li>
166166
<li>
@@ -183,6 +183,11 @@ describe('gcds-footer', () => {
183183
Youth
184184
</gcds-link>
185185
</li>
186+
<li>
187+
<gcds-link size="small" href="https://www.canada.ca/en/services/life-events.html">
188+
Manage life events
189+
</gcds-link>
190+
</li>
186191
</ul>
187192
</nav>
188193
</div>
@@ -389,7 +394,7 @@ describe('gcds-footer', () => {
389394
</li>
390395
<li>
391396
<gcds-link size="small" href="https://www.canada.ca/fr/services/finance.html">
392-
Argent et finance
397+
Argent et finances
393398
</gcds-link>
394399
</li>
395400
<li>
@@ -412,6 +417,11 @@ describe('gcds-footer', () => {
412417
Jeunesse
413418
</gcds-link>
414419
</li>
420+
<li>
421+
<gcds-link size="small" href="https://www.canada.ca/fr/services/evenements-vie.html">
422+
Gérer les événements de la vie
423+
</gcds-link>
424+
</li>
415425
</ul>
416426
</nav>
417427
</div>
@@ -596,7 +606,7 @@ describe('gcds-footer', () => {
596606
</li>
597607
<li>
598608
<gcds-link size="small" href="https://www.canada.ca/en/services/finance.html">
599-
Money and finance
609+
Money and finances
600610
</gcds-link>
601611
</li>
602612
<li>
@@ -619,6 +629,11 @@ describe('gcds-footer', () => {
619629
Youth
620630
</gcds-link>
621631
</li>
632+
<li>
633+
<gcds-link size="small" href="https://www.canada.ca/en/services/life-events.html">
634+
Manage life events
635+
</gcds-link>
636+
</li>
622637
</ul>
623638
</nav>
624639
</div>

0 commit comments

Comments
 (0)