Skip to content

Commit 98c37bd

Browse files
chore: upgrade PW v1.36.1 (#29)
Now compatible with: * lighthouse v10 * playwright-lighthouse v3.1 * TypeScript v5.1 * Node v18 * Faker v8 Upgrade GitHub Actions * actions/upload-artifact@v3 * mikepenz/action-junit-report@v3 * actions/checkout@v3 * actions/setup-node@v3
1 parent 6124136 commit 98c37bd

File tree

10 files changed

+1136
-735
lines changed

10 files changed

+1136
-735
lines changed

.github/workflows/playwright.yml

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -9,31 +9,33 @@ jobs:
99
timeout-minutes: 60
1010
runs-on: ubuntu-latest
1111
steps:
12-
- uses: actions/checkout@v2
13-
- uses: actions/setup-node@v2
12+
- uses: actions/checkout@v3
13+
- uses: actions/setup-node@v3
1414
with:
15-
node-version: '16.x'
15+
node-version: '18.x'
1616
- name: Install dependencies
1717
run: npm ci
1818
- name: Install Playwright
1919
run: npx playwright install --with-deps
2020
- name: Run Playwright tests
2121
run: npx playwright test
22+
env:
23+
API_KEY: ${{ secrets.API_KEY }}
2224
- name: Generate Allure Report
2325
if: always()
2426
run: npm run allure-report
25-
- uses: actions/upload-artifact@v2
27+
- uses: actions/upload-artifact@v3
2628
if: always()
2729
with:
2830
name: playwright-test-results
2931
path: test-results/
30-
- uses: actions/upload-artifact@v2
32+
- uses: actions/upload-artifact@v3
3133
if: always()
3234
with:
3335
name: allure-test-results
3436
path: allure-report/
3537
- name: Publish JUnit Report
36-
uses: mikepenz/action-junit-report@v2
38+
uses: mikepenz/action-junit-report@v3
3739
if: always() # always run even if the previous step fails
3840
with:
3941
report_paths: 'junit-results/*.xml'

README.md

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -83,15 +83,15 @@ In the `thresholds` section of the [lighthouse.spec.ts](./tests/lighthouse.spec.
8383

8484
If our threshold is 100 for `accessibility`, our test must have 100% acceptance to be considered successful.
8585

86-
```typescript
87-
thresholds: {
88-
performance: 50,
89-
accessibility: 100,
90-
'best-practices': 50,
91-
seo: 50,
92-
pwa: 0,
93-
},
94-
```
86+
```typescript
87+
thresholds: {
88+
performance: 50,
89+
accessibility: 100,
90+
'best-practices': 50,
91+
seo: 50,
92+
pwa: 0,
93+
},
94+
```
9595

9696
#### **To open Playwright's unified Html report of test results**
9797

0 commit comments

Comments
 (0)