Merge pull request #4 from chickensoft-games/feat/enumerable-id-types

feat: enumerate all id types

Author: Joanna May

Chickensoft.Introspection.Tests/test/TypeGraphTest.cs

@@ -28,6 +28,17 @@ public partial class SubtypeC : Model { }
   [Meta]
   public partial class NoSubtypes { }
 
+  [Fact]
+  public void EnumeratesRegisteredTypes() {
+    Types.Graph.IdentifiableTypes.ShouldContain(typeof(Model));
+    Types.Graph.IdentifiableTypes.ShouldContain(typeof(SubtypeA));
+    Types.Graph.IdentifiableTypes.ShouldContain(typeof(SubtypeA.SubtypeB));
+    Types.Graph.IdentifiableTypes.ShouldContain(typeof(SubtypeC));
+
+    // Not an identifiable type.
+    Types.Graph.IdentifiableTypes.ShouldNotContain(typeof(NoSubtypes));
+  }
+
   [Fact]
   public void GetIdentifiableType() =>
     Types.Graph.GetIdentifiableType("test_model").ShouldBe(typeof(Model));

Chickensoft.Introspection/src/TypeGraph.cs

@@ -10,8 +10,6 @@ namespace Chickensoft.Introspection;
 internal class TypeGraph : ITypeGraph {
   #region Caches
   private readonly ConcurrentDictionary<Type, ITypeMetadata> _types = new();
-  private readonly ConcurrentDictionary<Type, IIdentifiableTypeMetadata>
-    _identifiableTypes = new();
   private readonly ConcurrentDictionary<string, Dictionary<int, Type>>
     _identifiableTypesByIdAndVersion = new();
   private readonly ConcurrentDictionary<string, int>
@@ -34,7 +32,6 @@ private readonly ConcurrentDictionary<Type, Dictionary<Type, Attribute[]>>
 
   internal void Reset() {
     _types.Clear();
-    _identifiableTypes.Clear();
     _identifiableTypesByIdAndVersion.Clear();
     _identifiableLatestVersionsById.Clear();
     _typesByBaseType.Clear();
@@ -44,6 +41,10 @@ internal void Reset() {
   }
 
   #region ITypeGraph
+  public IEnumerable<Type> IdentifiableTypes => _identifiableTypesByIdAndVersion
+    .Values
+    .SelectMany(versions => versions.Values);
+
   public void Register(ITypeRegistry registry) {
     RegisterTypes(registry);
     PromoteInheritedIdentifiableTypes(registry);
@@ -120,9 +121,15 @@ _types[type] is not IIntrospectiveTypeMetadata metadata
         .Select(type => _types[type])
         .OfType<IIntrospectiveTypeMetadata>()
         .SelectMany((metadata) => metadata.Metatype.Attributes)
+        .GroupBy(
+          kvp => kvp.Key,
+          kvp => kvp.Value
+        )
         .ToDictionary(
-          keySelector: (typeToAttr) => typeToAttr.Key,
-          elementSelector: (typeToAttr) => typeToAttr.Value
+          group => group.Key,
+          elementSelector: group => group
+            .SelectMany(attributes => attributes)
+            .ToArray()
         );
     }
     return _attributes[type];

Chickensoft.Introspection/src/types/ITypeGraph.cs

@@ -11,6 +11,11 @@ namespace Chickensoft.Introspection;
 /// registered the types are represented in the graph, including nested types.
 /// </summary>
 public interface ITypeGraph {
+  /// <summary>
+  /// Enumerable of all registered (or promoted) identifiable types.
+  /// </summary>
+  IEnumerable<Type> IdentifiableTypes { get; }
+
   /// <summary>
   /// Computes and caches secondary type lookup tables based on the types
   /// registered in the provided type registry.