-
Notifications
You must be signed in to change notification settings - Fork 2
Open
Description
This theme currently overrides a theme-ui preset, inheriting unused styles and a color palette that is set in CSS variables. This issue covers improving the integration with theme UI. Some of the ways that can be done are listed below.
- Migrate off the theme preset. This may be more long term, and require defining our own custom theme and color palette.
- Ensure theme variables are being utilized in styles (see styles.js and look for styles that should be using
theme =>
). - Investigate whether theme styles should live in the component or live in a styles file. Currently they are spread between both those and the base theme index.js – three places!
- Until phased out, if the color palette for the theme preset isn't being used, should it be overridden so unused CSS variables aren't being set? Is there any harm or benefit in that?
Metadata
Metadata
Assignees
Labels
No labels