has_attractive_trait_trigger and related scripted_triggers #222
Description
While consistent with vanilla, the implementation and use of these is a bit odd/inconsistent.
Some examples:
- HF.21052 ("Swayed: Lustful swaying") treats these triggers as something that has to do with physical attractiveness since Blinded characters are excluded in the mult_modifier blocks, but the scripted_triggers both contain traits that have nothing to do with it (e.g. Gregarious, Stubborn) and don't check for being above the attraction cutoff.
- HF.23212 (Viking bloodline creation) might give a woman the "the Siren" nickname because she is... Just?
- assign_random_nickname_effect can hand out "the Beguiling/Handsome/Vain/Fair/Flower" to "attractive" characters. Even leaving aside whether the non-physical traits are odd, a Strong/Brawny character that's not also Attractive/Groomed probably shouldn't get those. Similarly, "unattractive" characters can get "the Hideous/Repulsive/Frog" for being Arbitrary. has_fair_trait_trigger/has_ugly_trait_trigger is probably more correct.
- The "Pregnancy glow" events (starting with HFP.20003) have different loc depending on the triggers and are all about looks, so a Craven woman with no "attractive" trait would apparently look just "passable" even if she had no other "unattractive" trait.
- The Pope/etc. is more likely to select a child that's "attractive" and/or smart and/or strong when demanding a child becomes a monk/nun in exchange for lifting your excommunication (HFP.23010). While I suppose e.g. losing a Brave child is more annoying than losing a Craven one, Attractive/Groomed (has_fair_trait_trigger) really seems like what's intended here since that's on another level.
- DW recruitment involves checks for "attractiveness" (and also explicitly for the Ugly trait), which seems odd.
- HF.20410 ("Liege receives homage from vassal") will claim it's hard to suffer the sight of such a repulsive man/woman as <"unattractive" vassal>, even if the vassal is just e.g. Stubborn with no "attractive" traits.
It would probably be a good idea to review where these triggers are used correctly (and contain the correct traits; it certainly isn't "Good/bad traits with sex_appeal_opinion", "Only physical appearance", or the like) and whether additional conditions are relevant (being attracted to men/women, not being Blinded, etc.) where they are used.