Skip to content

Commit f42f282

Browse files
authored
ci: turf off verbose logging for some tests (#698)
While diagnosing some safari on macos and firefox on windows I had turned on logging for ci. We can turn it back on if need be, but for now it is more noisy than helpful. And I suspect, might have been slowing ci testing for safari.
1 parent 7c9bbea commit f42f282

File tree

1 file changed

+11
-2
lines changed

1 file changed

+11
-2
lines changed

test/etaoin/api_test.clj

Lines changed: 11 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -47,12 +47,21 @@
4747

4848
(def default-opts
4949
{:chrome {}
50-
:firefox (cond-> {}
50+
:firefox {}
51+
#_
52+
;; I don't typically leave commented code in, but this might be nice to quickly turn
53+
;; back on for ci on windows someday
54+
(cond-> {}
5155
;; add logging for typically flaky CI scenario
5256
(and (ci?) (fs/windows?)) (merge {:log-stdout :inherit
5357
:log-stderr :inherit
5458
:driver-log-level "info"}))
55-
:safari (cond-> {}
59+
60+
:safari {}
61+
#_
62+
;; I don't typically leave commented code in, but this might be nice to quickly turn
63+
;; back on for ci someday, there are no log levels, it is extremely verbose or off
64+
(cond-> {}
5665
;; add logging for kind of flaky CI scenario (maybe we'll answer why we need
5766
;; to retry launching safaridriver automatically)
5867
(ci?) (merge {:log-stdout :inherit

0 commit comments

Comments
 (0)