From 154defd7ed0feef1bd2d31b2470d08b02d9bcebd Mon Sep 17 00:00:00 2001 From: lread Date: Fri, 18 Apr 2025 16:37:32 -0400 Subject: [PATCH] ci: turf off verbose logging for some tests While diagnosing some safari on macos and firefox on windows I had turned on logging for ci. We can turn it back on if need be, but for now it is more noisy than helpful. And I suspect, might have been slowing ci testing for safari. --- test/etaoin/api_test.clj | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/test/etaoin/api_test.clj b/test/etaoin/api_test.clj index cb96b30..e64cd64 100644 --- a/test/etaoin/api_test.clj +++ b/test/etaoin/api_test.clj @@ -47,12 +47,21 @@ (def default-opts {:chrome {} - :firefox (cond-> {} + :firefox {} + #_ + ;; I don't typically leave commented code in, but this might be nice to quickly turn + ;; back on for ci on windows someday + (cond-> {} ;; add logging for typically flaky CI scenario (and (ci?) (fs/windows?)) (merge {:log-stdout :inherit :log-stderr :inherit :driver-log-level "info"})) - :safari (cond-> {} + + :safari {} + #_ + ;; I don't typically leave commented code in, but this might be nice to quickly turn + ;; back on for ci someday, there are no log levels, it is extremely verbose or off + (cond-> {} ;; add logging for kind of flaky CI scenario (maybe we'll answer why we need ;; to retry launching safaridriver automatically) (ci?) (merge {:log-stdout :inherit