Initial version working with Pylint 1.5

Author: Aurore Dupuis

COPYING

@@ -0,0 +1,17 @@
+[MASTER]
+
+# List of plugins (as comma separated values of python modules names) to load,
+# usually to register additional checkers.
+load-plugins=cnes_checker,pylint.extensions.check_elif
+
+[DESIGN]
+
+# Maximum number of return / yield for function / method body
+max-returns=1
+
+# Maximum number of statements in function / method body
+max-statements=100
+
+# force the detection of all the missing parameters (docstrings with a mere
+# description won't be tolerated)
+accept-no-param-doc=n

checkers/__init__.py

@@ -0,0 +1,26 @@
+"""Checks the use of sys.exit() out of the module scope triggers a refactor
+message
+"""
+#pylint: disable=too-few-comments,missing-docstring-field
+
+import sys as s
+import sys
+from sys import exit as e
+
+def main():
+    """Calling sys.exit() from here is not a good practice"""
+    if True:
+        e(4)  # [sys-exit-used]
+    else:
+        s.exit(5)  # [sys-exit-used]
+
+e(6)
+toto.exit(10)
+exit(11)
+
+if True:
+    sys.exit(7)
+
+if __name__ == '__main__':
+    main()
+    sys.exit(1)

checkers/cnes_checker.py

@@ -0,0 +1,2 @@
+sys-exit-used:13:main:Consider dropping use of sys.exit()
+sys-exit-used:15:main:Consider dropping use of sys.exit()

pylintrc

@@ -0,0 +1,18 @@
+"""Checks that loop exit conditions don't use equality or difference comparison
+"""
+#pylint: disable=too-few-comments,missing-docstring-field
+string = '   hello world'
+i = 0
+while string[i] == ' ':  # [bad-exit-condition]
+    i += 1
+i = 0
+while string[i] != 'h':  # [bad-exit-condition]
+    i += 1
+while i < 5 and string[i] == ' ':  # [bad-exit-condition]
+    i += 1
+while i > 0:
+    i -= 1
+while True:
+    pass
+while string[i] == ' ' and True or i != 3:  # [bad-exit-condition]
+    pass

test/functional/__init__.py

@@ -0,0 +1,4 @@
+bad-exit-condition:6::Exit condition based on equality or difference
+bad-exit-condition:9::Exit condition based on equality or difference
+bad-exit-condition:11::Exit condition based on equality or difference
+bad-exit-condition:17::Exit condition based on equality or difference

test/functional/__main__.py

@@ -0,0 +1,23 @@
+"""Check no method nor attribute it named after a builtin"""
+#pylint: disable=too-few-comments,missing-docstring-field
+
+class MyClass(object):
+    def __init__(self):
+        ((self.file, (self.str, self.something)), plop) = (('test.txt', 'hello'), 'plop')  # [builtin-name-used, builtin-name-used]
+
+    bool = True  # [builtin-name-used]
+
+    def map(self):  # [builtin-name-used]
+        pass
+
+    def dummy_method(cls):
+        pass
+    zip = classmethod(dummy_method)  # [builtin-name-used]
+
+MyClass.dict = "hi there"  # [builtin-name-used]
+
+
+class ChildClass(MyClass):
+
+    def map(self):
+        """inherited: should be ok"""