Skip to content

Commit 55fc9a1

Browse files
committed
Fix validate_certs not used issue.
Fix #27. Now a provided `validate_certs` parameter is used in api connection.
1 parent 5dbf69b commit 55fc9a1

File tree

5 files changed

+19
-4
lines changed

5 files changed

+19
-4
lines changed

CHANGELOG.rst

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,14 @@ codeaffen.phpipam Release Notes
55
.. contents:: Topics
66

77

8+
v1.1.1
9+
======
10+
11+
Bugfixes
12+
--------
13+
14+
- Fix `validate_certs` is not used for api connection (https://github.com/codeaffen/phpipam-ansible-modules/issues/27)
15+
816
v1.1.0
917
======
1018

changelogs/changelog.yaml

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -51,3 +51,10 @@ releases:
5151
fragments:
5252
- missing_validate_certs_parameter.yml
5353
release_date: '2020-11-12'
54+
1.1.1:
55+
changes:
56+
bugfixes:
57+
- Fix `validate_certs` is not used for api connection (https://github.com/codeaffen/phpipam-ansible-modules/issues/27)
58+
fragments:
59+
- fix_validate_certs_not_used.yml
60+
release_date: '2020-11-12'

galaxy.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ name: "phpipam"
33
description: Ansible Modules to manage phpIPAM installations
44
authors:
55
- "Christian Meißner <cme+ansible@meissner.sh>"
6-
version: "1.1.0"
6+
version: "1.1.1"
77
license:
88
- "GPL-3.0-or-later"
99
tags:

plugins/module_utils/phpipam_helper.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,7 @@ def __init__(self, **kwargs):
8282
self._phpipamapi_app_id = self.phpipam_params.get('app_id')
8383
self._phpipamapi_username = self.phpipam_params.get('username')
8484
self._phpipamapi_password = self.phpipam_params.get('password')
85-
self._phpipamapi_ssl_verify = self.phpipam_params.get('ssl_verify', True)
85+
self._phpipamapi_validate_certs = self.phpipam_params.get('validate_certs', True)
8686
self._phpipamapi_path = kwargs.get('phpipam_path')
8787
self._phpipamapi_params = kwargs.get('phpipam_params')
8888

@@ -116,7 +116,7 @@ def connect(self):
116116
app_id=self._phpipamapi_app_id,
117117
username=self._phpipamapi_username,
118118
password=self._phpipamapi_password,
119-
ssl_verify=self._phpipamapi_ssl_verify,
119+
ssl_verify=self._phpipamapi_validate_certs,
120120
user_agent="phpipam-ansible-modules",
121121
)
122122

tests/test_playbooks/tasks/section.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,5 +16,5 @@
1616
show_vrf: "{{ section_show_vrf | default(omit) }}"
1717
show_supernets_only: "{{ section_show_supernets_only | default(omit) }}"
1818
dns_resolver: "{{ section_dns_resolver | default(omit) }}"
19-
validate_certs: "{{ section_validate_certs | default(omit) }}"
19+
validate_certs: "{{ section_validate_certs | default('no') }}"
2020
state: "{{ section_state | default('present') }}"

0 commit comments

Comments
 (0)