Skip to content

Commit d7b6c58

Browse files
authored
Merge pull request #210 from rhatdan/pidslimit
PidsLimit should return 0 if rootless and cgroupfs manager
2 parents 80e4318 + eab5ee5 commit d7b6c58

File tree

1 file changed

+7
-7
lines changed

1 file changed

+7
-7
lines changed

pkg/config/default.go

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@ import (
1111

1212
"github.com/containers/common/pkg/apparmor"
1313
"github.com/containers/common/pkg/cgroupv2"
14-
"github.com/containers/common/pkg/sysinfo"
1514
"github.com/containers/storage"
1615
"github.com/containers/storage/pkg/unshare"
1716
"github.com/opencontainers/selinux/go-selinux"
@@ -484,15 +483,16 @@ func (c *Config) Ulimits() []string {
484483
// PidsLimit returns the default maximum number of pids to use in containers
485484
func (c *Config) PidsLimit() int64 {
486485
if unshare.IsRootless() {
487-
if c.Engine.CgroupManager == SystemdCgroupsManager {
488-
cgroup2, _ := cgroupv2.Enabled()
489-
if cgroup2 {
490-
return c.Containers.PidsLimit
491-
}
486+
if c.Engine.CgroupManager != SystemdCgroupsManager {
487+
return 0
488+
}
489+
cgroup2, _ := cgroupv2.Enabled()
490+
if !cgroup2 {
492491
return 0
493492
}
494493
}
495-
return sysinfo.GetDefaultPidsLimit()
494+
495+
return c.Containers.PidsLimit
496496
}
497497

498498
// DetachKeys returns the default detach keys to detach from a container

0 commit comments

Comments
 (0)