Skip to content

Commit e5cfc9d

Browse files
authored
Merge pull request #212 from rhatdan/v0.14
PidsLimit should return 0 if rootless and cgroupfs manager
2 parents 33cd1bc + 1d7d264 commit e5cfc9d

File tree

1 file changed

+7
-7
lines changed

1 file changed

+7
-7
lines changed

pkg/config/default.go

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@ import (
1111

1212
"github.com/containers/common/pkg/apparmor"
1313
"github.com/containers/common/pkg/cgroupv2"
14-
"github.com/containers/common/pkg/sysinfo"
1514
"github.com/containers/storage"
1615
"github.com/containers/storage/pkg/unshare"
1716
"github.com/opencontainers/selinux/go-selinux"
@@ -483,15 +482,16 @@ func (c *Config) Ulimits() []string {
483482
// PidsLimit returns the default maximum number of pids to use in containers
484483
func (c *Config) PidsLimit() int64 {
485484
if unshare.IsRootless() {
486-
if c.Engine.CgroupManager == SystemdCgroupsManager {
487-
cgroup2, _ := cgroupv2.Enabled()
488-
if cgroup2 {
489-
return c.Containers.PidsLimit
490-
}
485+
if c.Engine.CgroupManager != SystemdCgroupsManager {
486+
return 0
487+
}
488+
cgroup2, _ := cgroupv2.Enabled()
489+
if !cgroup2 {
491490
return 0
492491
}
493492
}
494-
return sysinfo.GetDefaultPidsLimit()
493+
494+
return c.Containers.PidsLimit
495495
}
496496

497497
// DetachKeys returns the default detach keys to detach from a container

0 commit comments

Comments
 (0)