Skip to content

Commit 59f8e9f

Browse files
R-Delfino95Jerricho93david-shibley-contentful
authored
Mux app: new features (#9826)
* Added modal before the upload of the asset. Added option to select video quality * Added styling for the upload container. Code refactoring. Fixed tests. * Added help description for the video quality option. * Change default quality to "Plus" Added description based on selected quality. Removed duplicated code. * Added show modal when it's a URL case. * Added video and audio restriction * Change styling of the quality options * Modal refactor into components. Added Playback policy options. [WIP] Added captions (working but remains validations and UI bugs). * Fixed captions components align * Added validations for captions types. Renamed Captions component props. Refactor of Beta language validations * Added modal subcomponent for reset state * Added MP4 renditions option * Added MP4 renditions panel with download, create and delete actions. Refactored endpoints logic into new file. * Fixed render error while creating/removing captions * Removed unnecessary timers * Added optional flag for no resync player in rendition cases * Added skipped status case with tooltip reason * Added upload metadata information in Upload Asset modal. Updated mux player library to latest Mux API refactor for upload by URL or direct upload. Refactor of modal state * Added state for unique polling. Added asset sync at first render. * Commited Github suggestions * Implemented edit metadata through "Edit" button under the asset player * Renamed Modal. Removed unused passthroughId in Asset Metadata * Implemented add and remove audio tracks. Caption tab refactor into component and reuse it for audio * Fixed note spaces. Fixed set captions when uploading an Asset * Removed unused component. TrackList refactor and added data-test. Fixed some tests * Added missing download link. Fixed tests * Removed "Edit" button. Moved Metadata as a new Tab. Added styling and scrollable Tab. * Removed metadata Switch in Asset creation * Added optional title sync while creating a new Asset * Added sync title from Content model to override Mux Asset title in the metadata tab. * Added txt transcript for captions. Added download option when it's a Signed asset. * Added default state for audio list. Removed redundant track in the audio title * Updated plugin version Added auto generated captions option while updating an existing Asset. Added transcript option if the caption is autogenerated. * Added onPublish function to sync playbackId swap Added sync of publish event in frontend Removed logic for swap playbackId in front and moved to function. * onPublish function refactor * Added remaining actions * Added undo option for pendingActions * fixed typos * Added remove asset first in Function * Fixed wrong updated fields from Mux * Added remove entry from Contentful when the asset was removed * Changed Checkbox to Radios * Fixed update fields * Added asset deletion to pendingActions * Added mock to fix tests * Created interface for addByURL config parameters. Removed commented code. Renamed in_progress status to inProgress. Interfaces refactor for reuse * Applied prettier format * Added changes * Fixed linter * Sidebar refactor * Implemented iframe tab for Player Code * Renamed PlayerSnippet to PlayerCode. Remove unused Tab content * Updated metadata. Fix function VersionMismatch * Added retry mechanism for pendingActions. * Fixed missing update in pending actions. --------- Co-authored-by: Manuel Calleriza <mcalleriza@mux.com> Co-authored-by: david-shibley-contentful <149433784+david-shibley-contentful@users.noreply.github.com>
1 parent a23a136 commit 59f8e9f

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

42 files changed

+7554
-775
lines changed

apps/mux/README.md

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,11 +2,10 @@
22

33
Contentful Marketplace App that allows customers to link to and work with Mux-hosted video assets.
44

5-
65
## Front End
76

87
See the [front end README](./frontend/README.md) for more information about using and working with the front end.
98

109
## App Actions
1110

12-
This app relies on app actions to correctly sign JWT tokens in a secure context.
11+
This app relies on app actions to correctly sign JWT tokens in a secure context.

apps/mux/frontend/README.md

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -11,21 +11,21 @@
1111

1212
## Contentful app setup
1313

14-
* Use the Mux (dev) contentful app and make sure it is pointed to http://localhost:3000 for development
15-
* Create a development app in Contentful. Try to only select the resources needed.
16-
* You will have to go into your browser settings and disable mixed content warnings for this to work
17-
* Contentful uses Conventional Commits.
18-
* Squash commit history.
19-
* Use Node 14.
20-
* Use Prettier for formatting.
14+
- Use the Mux (dev) contentful app and make sure it is pointed to http://localhost:3000 for development
15+
- Create a development app in Contentful. Try to only select the resources needed.
16+
- You will have to go into your browser settings and disable mixed content warnings for this to work
17+
- Contentful uses Conventional Commits.
18+
- Squash commit history.
19+
- Use Node 14.
20+
- Use Prettier for formatting.
2121

2222
## Existing Videos and Captions
2323

24-
Captions and subtitles (using the terms interchangeably here) are bundled and delivered with the video during playback, and is ultimately the source of truth. For other UI uses, the captions are included in the data object so the video manifest does not have to be downloaded. For existing videos, workflows may have already added captions on some videos, and will continue to work in players even if they are not reflected in data stored in Contentful. To update the Contentful data on the video, press the "resync" button to sync to the latest state of the video.
24+
Captions and subtitles (using the terms interchangeably here) are bundled and delivered with the video during playback, and is ultimately the source of truth. For other UI uses, the captions are included in the data object so the video manifest does not have to be downloaded. For existing videos, workflows may have already added captions on some videos, and will continue to work in players even if they are not reflected in data stored in Contentful. To update the Contentful data on the video, press the "resync" button to sync to the latest state of the video.
2525

2626
## Deploy
2727

28-
* This gets deployed and hosted by Contentful
28+
- This gets deployed and hosted by Contentful
2929

3030
## Object Version
3131

apps/mux/frontend/package-lock.json

Lines changed: 94 additions & 47 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

apps/mux/frontend/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@contentful/mux-contentful-frontend",
3-
"version": "1.10.14",
3+
"version": "2.0.0",
44
"private": true,
55
"devDependencies": {
66
"@testing-library/jest-dom": "5.17.0",
@@ -23,7 +23,7 @@
2323
"@contentful/dam-app-base": "2.0.46",
2424
"@contentful/f36-components": "4.67.0",
2525
"@contentful/react-apps-toolkit": "1.2.16",
26-
"@mux/mux-player-react": "2.9.1",
26+
"@mux/mux-player-react": "3.4.0",
2727
"@mux/mux-uploader-react": "1.0.1",
2828
"@vitejs/plugin-react": "^4.3.2",
2929
"jsdom": "^25.0.1",

0 commit comments

Comments
 (0)