Skip to content

Commit 2599688

Browse files
committed
Bootstrap fixes
1. "preventAssignment: true" broke Bootstrap version (Uncaught ReferenceError: bsKeys is not defined) 2. Fix for hardcoded "cui" prefix in _dropdown.scss (broked Boostrap version)
1 parent 4e5ca2b commit 2599688

File tree

2 files changed

+4
-6
lines changed

2 files changed

+4
-6
lines changed

build/rollup.config.mjs

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -22,12 +22,10 @@ const plugins = [
2222
babelHelpers: 'bundled'
2323
}),
2424
BOOTSTRAP && replace({
25-
preventAssignment: true,
25+
preventAssignment: false,
2626
delimiters: ['', ''],
2727
'/coreui': '/coreui', // prevents changes in URLs
28-
coreui: 'bs',
29-
'-coreui': '-bs',
30-
'coreui=': 'bs=', // [data-coreui="navigation"] => [data-bs="navigation"] (workaround for `preventAssignment` being true),
28+
'coreui': 'bs',
3129
'--cui-': '--bs-'
3230
})
3331
]

scss/_dropdown.scss

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,7 @@
9191
$infix: breakpoint-infix($breakpoint, $grid-breakpoints);
9292

9393
.dropdown-menu#{$infix}-start {
94-
--cui-position: start;
94+
--#{$prefix}position: start;
9595

9696
&[data-coreui-popper] {
9797
@include ltr-rtl("right", auto);
@@ -100,7 +100,7 @@
100100
}
101101

102102
.dropdown-menu#{$infix}-end {
103-
--cui-position: end;
103+
--#{$prefix}position: end;
104104

105105
&[data-coreui-popper] {
106106
@include ltr-rtl("right", 0);

0 commit comments

Comments
 (0)