lint fix and changes

Author: technicallyty

app/keepers/keepers.go

@@ -590,11 +590,11 @@ func initParamsKeeper(appCodec codec.BinaryCodec, legacyAmino *codec.LegacyAmino
 	// register the key tables for legacy param subspaces
 	keyTable := ibcclienttypes.ParamKeyTable()
 	keyTable.RegisterParamSet(&ibcconnectiontypes.Params{})
-	paramsKeeper.Subspace(authtypes.ModuleName).WithKeyTable(authtypes.ParamKeyTable())         //nolint: staticcheck
-	paramsKeeper.Subspace(stakingtypes.ModuleName).WithKeyTable(stakingtypes.ParamKeyTable())   //nolint: staticcheck // SA1019
-	paramsKeeper.Subspace(banktypes.ModuleName).WithKeyTable(banktypes.ParamKeyTable())         //nolint: staticcheck // SA1019
-	paramsKeeper.Subspace(minttypes.ModuleName).WithKeyTable(minttypes.ParamKeyTable())         //nolint: staticcheck // SA1019
-	paramsKeeper.Subspace(distrtypes.ModuleName).WithKeyTable(distrtypes.ParamKeyTable())       //nolint: staticcheck // SA1019
+	paramsKeeper.Subspace(authtypes.ModuleName).WithKeyTable(authtypes.ParamKeyTable())
+	paramsKeeper.Subspace(stakingtypes.ModuleName).WithKeyTable(stakingtypes.ParamKeyTable())
+	paramsKeeper.Subspace(banktypes.ModuleName).WithKeyTable(banktypes.ParamKeyTable()) //nolint: staticcheck // SA1019
+	paramsKeeper.Subspace(minttypes.ModuleName).WithKeyTable(minttypes.ParamKeyTable()) //nolint: staticcheck // SA1019
+	paramsKeeper.Subspace(distrtypes.ModuleName).WithKeyTable(distrtypes.ParamKeyTable())
 	paramsKeeper.Subspace(slashingtypes.ModuleName).WithKeyTable(slashingtypes.ParamKeyTable()) //nolint: staticcheck // SA1019
 	paramsKeeper.Subspace(govtypes.ModuleName).WithKeyTable(govv1.ParamKeyTable())              //nolint: staticcheck // SA1019
 	paramsKeeper.Subspace(ibcexported.ModuleName).WithKeyTable(keyTable)

app/sim/sim_utils.go

@@ -36,7 +36,7 @@ func SimulationOperations(app *gaia.GaiaApp, cdc codec.JSONCodec, config simtype
 	}
 
 	// TODO: update deprecated code.
-	simState.LegacyProposalContents = app.SimulationManager().GetProposalContents(simState) //nolint:staticcheck
+	simState.LegacyProposalContents = app.SimulationManager().GetProposalContents(simState)
 	simState.ProposalMsgs = app.SimulationManager().GetProposalMsgs(simState)
 	return app.SimulationManager().WeightedOperations(simState)
 }

app/sim_test.go

@@ -56,8 +56,8 @@ func TestAppStateDeterminism(t *testing.T) {
 	config.InitialBlockHeight = 1
 	config.ExportParamsPath = ""
 	// TODO: update deprecated code.
-	config.OnOperation = false   //nolint:staticcheck
-	config.AllInvariants = false //nolint:staticcheck
+	config.OnOperation = false
+	config.AllInvariants = false
 	config.GenesisTime = time.Now().UTC().Unix()
 	config.ChainID = AppChainID
 

cmd/gaiad/cmd/testnet.go

@@ -4,7 +4,6 @@ import (
 	"bufio"
 	"encoding/json"
 	"fmt"
-	"math/rand"
 	"net"
 	"os"
 	"path/filepath"
@@ -64,7 +63,6 @@ var (
 	flagAPIAddress         = "api.address"
 	flagPrintMnemonic      = "print-mnemonic"
 	unsafeStartValidatorFn UnsafeStartValidatorCmdCreator
-	strChars               = "0123456789ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz" // 62 characters
 )
 
 type UnsafeStartValidatorCmdCreator func(ac appCreator) *cobra.Command
@@ -166,9 +164,6 @@ Example:
 			args.keyringBackend, _ = cmd.Flags().GetString(flags.FlagKeyringBackend)
 			args.chainID, _ = cmd.Flags().GetString(flags.FlagChainID)
 			args.useDocker, _ = cmd.Flags().GetBool(flagsUseDocker)
-			if args.chainID == "" {
-				args.chainID = "localchain"
-			}
 			args.minGasPrices, _ = cmd.Flags().GetString(server.FlagMinGasPrices)
 			args.nodeDirPrefix, _ = cmd.Flags().GetString(flagNodeDirPrefix)
 			args.nodeDaemonHome, _ = cmd.Flags().GetString(flagNodeDaemonHome)
@@ -240,11 +235,7 @@ func initTestnetFiles(
 	args initArgs,
 ) error {
 	if args.chainID == "" {
-		chainID := []byte("chain-")
-		for i := 0; i < 6; i++ {
-			chainID = append(chainID, strChars[rand.Int()%len(strChars)])
-		}
-		args.chainID = string(chainID)
+		args.chainID = "localchain"
 	}
 	nodeIDs := make([]string, args.numValidators)
 	valPubKeys := make([]cryptotypes.PubKey, args.numValidators)
@@ -256,15 +247,15 @@ func initTestnetFiles(
 	serverCfg.Telemetry.PrometheusRetentionTime = 60
 	serverCfg.Telemetry.EnableHostnameLabel = false
 	serverCfg.Telemetry.GlobalLabels = [][]string{{"chain_id", args.chainID}}
-	telConfig := telemetry.LocalOtelConfig
+	otelConfig := telemetry.LocalOtelConfig
 	if args.useDocker {
 		// if useDocker, we need to use the docker networking. localhost is troublesome in the setup.
-		telConfig.CollectorEndpoint = "host.docker.internal:4318"
+		otelConfig.CollectorEndpoint = "host.docker.internal:4318"
 	}
 	gaiaCfg := gaia.AppConfig{
 		Config:        *serverCfg,
 		Wasm:          wasmtypes.NodeConfig{},
-		OpenTelemetry: telConfig,
+		OpenTelemetry: otelConfig,
 	}
 
 	var (

telemetry/otel.go

@@ -88,6 +88,7 @@ func (o *OtelClient) StartExporter(logger log.Logger) error {
 			"Authorization": "Basic " + formatBasicAuth(cfg.User, cfg.Token),
 		}))
 	} else if strings.HasPrefix(cfg.CollectorEndpoint, "localhost") || strings.HasPrefix(cfg.CollectorEndpoint, "host.docker.internal") {
+		// host.docker.internal is the endpoint for docker containers to communicate with the host computer.
 		opts = append(opts, otlpmetrichttp.WithInsecure())
 	}