CBG-4797: make GetCV mirror GetRev and add request for history to it (#7673)

Author: gregns1

db/blip_handler.go

@@ -1153,7 +1153,7 @@ func (bh *blipHandler) processRev(rq *blip.Message, stats *processRevStats) (err
 			if parseErr != nil {
 				return base.HTTPErrorf(http.StatusUnprocessableEntity, "Unable to parse version for delta source for doc %s, error: %v", base.UD(docID), err)
 			}
-			deltaSrcRev, err = bh.collection.GetCV(bh.loggingCtx, docID, &deltaSrcVersion)
+			deltaSrcRev, err = bh.collection.GetCV(bh.loggingCtx, docID, &deltaSrcVersion, false)
 		} else {
 			deltaSrcRev, err = bh.collection.GetRev(bh.loggingCtx, docID, deltaSrcRevID, false, nil)
 		}

db/blip_sync_context.go

@@ -687,7 +687,7 @@ func (bsc *BlipSyncContext) sendRevision(ctx context.Context, sender *blip.Sende
 		if vrsErr != nil {
 			return vrsErr
 		}
-		docRev, originalErr = handleChangesResponseCollection.GetCV(bsc.loggingCtx, docID, &version)
+		docRev, originalErr = handleChangesResponseCollection.GetCV(bsc.loggingCtx, docID, &version, true)
 	}
 
 	// set if we find an alternative revision to send in the event the originally requested rev is unavailable

db/crud.go

@@ -437,7 +437,7 @@ func (db *DatabaseCollectionWithUser) documentRevisionForRequest(ctx context.Con
 	return revision, nil
 }
 
-func (db *DatabaseCollectionWithUser) GetCV(ctx context.Context, docid string, cv *Version) (revision DocumentRevision, err error) {
+func (db *DatabaseCollectionWithUser) GetCV(ctx context.Context, docid string, cv *Version, revTreeHistory bool) (revision DocumentRevision, err error) {
 	if cv != nil {
 		revision, err = db.revisionCache.GetWithCV(ctx, docid, cv, RevCacheOmitDelta)
 	} else {
@@ -446,8 +446,12 @@ func (db *DatabaseCollectionWithUser) GetCV(ctx context.Context, docid string, c
 	if err != nil {
 		return DocumentRevision{}, err
 	}
+	maxHistory := 0
+	if revTreeHistory {
+		maxHistory = math.MaxInt32
+	}
 
-	return db.documentRevisionForRequest(ctx, docid, revision, nil, cv, 0, nil)
+	return db.documentRevisionForRequest(ctx, docid, revision, nil, cv, maxHistory, nil)
 }
 
 // GetDelta attempts to return the delta between fromRevId and toRevId.  If the delta can't be generated,

db/crud_test.go

@@ -1959,7 +1959,7 @@ func TestGetCVWithDocResidentInCache(t *testing.T) {
 			vrs := doc.HLV.Version
 			src := doc.HLV.SourceID
 			sv := &Version{Value: vrs, SourceID: src}
-			revision, err := collection.GetCV(ctx, docID, sv)
+			revision, err := collection.GetCV(ctx, docID, sv, false)
 			require.NoError(t, err)
 			if testCase.access {
 				assert.Equal(t, rev, revision.RevID)
@@ -2018,7 +2018,7 @@ func TestGetByCVForDocNotResidentInCache(t *testing.T) {
 	vrs := doc.HLV.Version
 	src := doc.HLV.SourceID
 	sv := &Version{Value: vrs, SourceID: src}
-	revision, err := collection.GetCV(ctx, doc1ID, sv)
+	revision, err := collection.GetCV(ctx, doc1ID, sv, false)
 	require.NoError(t, err)
 
 	// assert the fetched doc is the first doc we added and assert that we did in fact get cache miss
@@ -2072,7 +2072,7 @@ func TestGetCVActivePathway(t *testing.T) {
 			revBody := Body{"channels": testCase.docChannels}
 			rev, doc, err := collection.Put(ctx, docID, revBody)
 			require.NoError(t, err)
-			revision, err := collection.GetCV(ctx, docID, nil)
+			revision, err := collection.GetCV(ctx, docID, nil, false)
 
 			if testCase.access == true {
 				require.NoError(t, err)