CBG-4810 blip test: separate user creation (#7686)

Author: torcolvin

rest/adminapitest/admin_api_test.go

@@ -396,7 +396,7 @@ func TestFlush(t *testing.T) {
 
 	log.Printf("Flushing db...")
 	rest.RequireStatus(t, rt.SendAdminRequest("POST", "/db/_flush", ""), 200)
-	require.NoError(t, rt.SetAdminParty(true)) // needs to be re-enabled after flush since guest user got wiped
+	rt.SetAdminParty(true) // needs to be re-enabled after flush since guest user got wiped
 
 	// After the flush, the db exists but the documents are gone:
 	rest.RequireStatus(t, rt.SendAdminRequest("GET", "/db/", ""), 200)

rest/attachment_test.go

@@ -2438,10 +2438,9 @@ func TestProveAttachmentNotFound(t *testing.T) {
 	dbConfig := rt.NewDbConfig()
 	dbConfig.AllowConflicts = base.Ptr(true)
 	RequireStatus(t, rt.CreateDatabase("db", dbConfig), http.StatusCreated)
-	require.NoError(t, rt.SetAdminParty(true))
+	rt.SetAdminParty(true)
 
-	bt, err := NewBlipTesterFromSpecWithRT(t, nil, rt)
-	assert.NoError(t, err, "Error creating BlipTester")
+	bt := NewBlipTesterFromSpecWithRT(rt, nil)
 	defer bt.Close()
 
 	attachmentData := []byte("attachmentA")
@@ -2527,13 +2526,10 @@ func TestPutInvalidAttachment(t *testing.T) {
 
 	base.SetUpTestLogging(t, base.LevelInfo, base.KeyHTTP, base.KeySync, base.KeySyncMsg)
 
-	// Create blip tester
-	bt, err := NewBlipTesterFromSpec(t, BlipTesterSpec{
-		connectingUsername:          "user1",
-		connectingPassword:          "1234",
-		connectingUserChannelGrants: []string{"*"}, // All channels
+	const username = "user1"
+	bt := NewBlipTesterFromSpec(t, BlipTesterSpec{
+		connectingUsername: username,
 	})
-	require.NoError(t, err, "Unexpected error creating BlipTester")
 	defer bt.Close()
 
 	for _, test := range tests {
@@ -2878,6 +2874,7 @@ func TestBlipPushRevWithAttachment(t *testing.T) {
 		rt := NewRestTesterPersistentConfig(t)
 		defer rt.Close()
 		const username = "bernard"
+		rt.CreateUser(username, nil)
 
 		opts := &BlipTesterClientOpts{Username: username, SupportedBLIPProtocols: SupportedBLIPProtocols}
 		btc := btcRunner.NewBlipTesterClientOptsWithRT(rt, opts)

rest/blip_api_attachment_test.go

@@ -413,13 +413,10 @@ func TestPutAttachmentViaBlipGetViaRest(t *testing.T) {
 
 	base.SetUpTestLogging(t, base.LevelInfo, base.KeyHTTP, base.KeySync, base.KeySyncMsg)
 
-	// Create blip tester
-	bt, err := NewBlipTesterFromSpec(t,
+	bt := NewBlipTesterFromSpec(t,
 		BlipTesterSpec{
 			connectingUsername: "user1",
-			connectingPassword: "1234",
 		})
-	require.NoError(t, err)
 	defer bt.Close()
 
 	attachmentBody := "attach"
@@ -458,13 +455,9 @@ func TestPutAttachmentViaBlipGetViaRest(t *testing.T) {
 func TestPutAttachmentViaBlipGetViaBlip(t *testing.T) {
 	base.SetUpTestLogging(t, base.LevelInfo, base.KeyHTTP, base.KeySync, base.KeySyncMsg)
 
-	// Create blip tester
-	bt, err := NewBlipTesterFromSpec(t, BlipTesterSpec{
-		connectingUsername:          "user1",
-		connectingPassword:          "1234",
-		connectingUserChannelGrants: []string{"*"}, // All channels
+	bt := NewBlipTesterFromSpec(t, BlipTesterSpec{
+		GuestEnabled: true,
 	})
-	require.NoError(t, err)
 	defer bt.Close()
 
 	attachmentBody := "attach"