Skip to content

Commit feebe5a

Browse files
authored
CBG-4768: add missing silent handler logging level for admin port _expvar (#7646)
1 parent 7ded498 commit feebe5a

File tree

2 files changed

+6
-1
lines changed

2 files changed

+6
-1
lines changed

rest/api_test.go

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3205,4 +3205,9 @@ func TestSilentHandlerLoggingInTrace(t *testing.T) {
32053205
resp := rt.SendMetricsRequestWithHeaders(http.MethodGet, "/_expvar", "", headers)
32063206
RequireStatus(t, resp, http.StatusOK)
32073207
})
3208+
3209+
base.AssertLogNotContains(t, "/_expvar", func() {
3210+
resp := rt.SendAdminRequest(http.MethodGet, "/_expvar", "")
3211+
RequireStatus(t, resp, http.StatusOK)
3212+
})
32083213
}

rest/routing.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -287,7 +287,7 @@ func CreateAdminRouter(sc *ServerContext) *mux.Router {
287287
makeHandler(sc, adminPrivs, []Permission{PermStatsExport}, nil, (*handler).handleStats)).Methods("GET")
288288
r.Handle(kDebugURLPathPrefix,
289289
makeHandlerWithOptions(sc, adminPrivs, []Permission{PermStatsExport}, nil, (*handler).handleExpvar, handlerOptions{
290-
httpLogLevel: base.Ptr(base.LevelDebug), // silent handler
290+
httpLogLevel: base.Ptr(silentRequestLogLevel), // silent handler
291291
sgcollect: true,
292292
})).Methods("GET")
293293
r.Handle("/_profile/{profilename}",

0 commit comments

Comments
 (0)