Code cleanup

Author: cowwoc

.github/workflows/build.yml

@@ -21,8 +21,7 @@ jobs:
       - name: Cache Dependencies
         uses: actions/cache@v4
         with:
-          path: |
-            ~/.m2/repository/*
+          path: ~/.m2/repository/*
           key: ${{ runner.OS }}-maven-${{ hashFiles('**/pom.xml') }}
 
       # Maven command-line options:

.github/workflows/deploy_to_maven_central.yml

@@ -104,6 +104,8 @@ jobs:
       - uses: actions/checkout@v4
         with:
           ref: ${{ needs.open-release.outputs.TAG }}
+          token: ${{ secrets.WORKFLOW_TOKEN }}
+          fetch-depth: 0
       - uses: actions/setup-java@v4
         with:
           distribution: zulu
@@ -132,29 +134,9 @@ jobs:
           -Dstaging_host="${{ env.STAGING_HOST }}"
           deploy -P release
 
-  document:
-    name: Publish Javadoc documentation
-    needs: [ open-release, deploy ]
-    runs-on: ubuntu-latest
-    steps:
-      - uses: actions/checkout@v4
-        with:
-          ref: ${{ needs.open-release.outputs.TAG }}
-          fetch-depth: 0
-          token: ${{ secrets.WORKFLOW_TOKEN }}
-      - uses: actions/setup-java@v4
-        with:
-          distribution: zulu
-          java-version: 21
-
-      - name: Configure Git User
-        run: |
-          git config user.email "cowwoc2020@gmail.com"
-          git config user.name "Gili Tzabari"
-
       - name: Generate Javadoc
         run: |
-          ./mvnw --batch-mode -V -e verify javadoc:aggregate
+          ./mvnw --batch-mode -V -e javadoc:aggregate
           mkdir --parents "${{ needs.open-release.outputs.VERSION }}/docs"
           mv target/reports/apidocs "${{ needs.open-release.outputs.VERSION }}/docs/api"
 
@@ -167,7 +149,7 @@ jobs:
           git push
 
   close-release:
-    needs: [ open-release, deploy, document ]
+    needs: [ open-release, deploy ]
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v4
@@ -207,8 +189,8 @@ jobs:
       - uses: actions/checkout@v4
         with:
           ref: ${{ github.ref }}
-          fetch-depth: 0
           token: ${{ secrets.WORKFLOW_TOKEN }}
+          fetch-depth: 0
       - uses: actions/setup-java@v4
         with:
           distribution: zulu