Skip to content

Commit 0546cef

Browse files
committed
datasets: Fix dataset loader
1 parent 1f375f3 commit 0546cef

File tree

2 files changed

+8
-4
lines changed

2 files changed

+8
-4
lines changed

CHANGES.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,8 @@
33

44
## Unreleased
55

6+
- datasets: Fix dataset loader
7+
68

79
## 2024/03/07 v0.0.6
810

cratedb_toolkit/datasets/model.py

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -103,10 +103,12 @@ def load(
103103
cardinality = self.db.count_records(self.table, errors="ignore")
104104
has_data = cardinality > 0
105105

106-
if not has_data and not if_exists == "noop":
107-
if self.init_sql is None:
108-
raise ValueError("SQL for loading data is missing")
109-
self.run_sql(self.init_sql)
106+
if if_exists == "noop" and has_data:
107+
return
108+
109+
if self.init_sql is None:
110+
raise ValueError("SQL for loading data is missing")
111+
self.run_sql(self.init_sql)
110112

111113
def run_sql(self, sql: str):
112114
for statement in sqlparse.parse(sql):

0 commit comments

Comments
 (0)