Make compiler more strict (Xlint) and fix warnings

Author: bwaldvogel

build.gradle

@@ -32,7 +32,10 @@ java {
     targetCompatibility = JavaVersion.VERSION_17
 }
 
-compileJava.options.encoding = 'UTF-8'
+tasks.withType(JavaCompile) {
+    options.encoding = 'UTF-8'
+    options.compilerArgs.addAll(['-Xlint:all,-serial,-overloads,-classfile', '-Werror'])
+}
 
 dependencies {
     components.all { ComponentMetadataDetails details ->

src/main/java/de/cronn/reflection/util/ClassUtils.java

@@ -78,7 +78,7 @@ public static <T> T createNewInstance(Class<T> sourceClass) {
 	}
 
 	static <T> T createInstance(Constructor<T> constructor, Object... initArgs) throws ReflectiveOperationException {
-		boolean accessible = constructor.isAccessible();
+		boolean accessible = constructor.canAccess(null);
 		try {
 			if (!accessible) {
 				constructor.setAccessible(true);

src/main/java/de/cronn/reflection/util/PropertyUtils.java

@@ -160,7 +160,7 @@ public static void write(Object destination, PropertyDescriptor propertyDescript
 			} else {
 				Object[] args = new Object[] { value };
 				Method writeMethod = propertyDescriptor.getWriteMethod();
-				withAccessibleObject(writeMethod, method -> method.invoke(destination, args), force);
+				withAccessibleObject(destination, writeMethod, (dest, method) -> method.invoke(dest, args), force);
 			}
 		} catch (ReflectiveOperationException | RuntimeException e) {
 			throw new ReflectionRuntimeException("Failed to write " + getQualifiedPropertyName(destination, propertyDescriptor), e);
@@ -183,7 +183,7 @@ public static void writeDirectly(Object destination, String propertyName, Object
 	public static void writeDirectly(Object destination, Field field, Object value) {
 		Assert.notNull(destination, () -> "Destination must not be null");
 		try {
-			withAccessibleObject(field, f -> f.set(destination, value));
+			withAccessibleObject(destination, field, (obj, f) -> f.set(obj, value));
 		} catch (ReflectiveOperationException e) {
 			throw new ReflectionRuntimeException("Failed to write " + getQualifiedPropertyName(destination, field), e);
 		}
@@ -216,9 +216,9 @@ public static <T> T readDirectly(Object object, String propertyName) {
 
 	public static <T> T readDirectly(Object object, Field field) {
 		try {
-			return withAccessibleObject(field, f -> {
+			return withAccessibleObject(object, field, (obj, f) -> {
 				@SuppressWarnings("unchecked")
-				T value = (T) field.get(object);
+				T value = (T) field.get(obj);
 				return value;
 			}, true);
 		} catch (ReflectiveOperationException e) {
@@ -241,7 +241,7 @@ public static <T> T read(Object source, PropertyDescriptor propertyDescriptor, b
 				}
 			} else {
 				Method readMethod = propertyDescriptor.getReadMethod();
-				result = withAccessibleObject(readMethod, method -> readMethod.invoke(source), force);
+				result = withAccessibleObject(source, readMethod, (src, method) -> method.invoke(src), force);
 			}
 		} catch (ReflectiveOperationException | RuntimeException e) {
 			throw new ReflectionRuntimeException("Failed to read " + getQualifiedPropertyName(source, propertyDescriptor), e);
@@ -449,28 +449,28 @@ public static boolean isNotCollectionType(PropertyDescriptor propertyDescriptor)
 		return !isCollectionType(propertyDescriptor);
 	}
 
-	private interface AccessibleObjectFunction<T extends AccessibleObject, R> {
-		R access(T object) throws ReflectiveOperationException;
+	private interface AccessibleObjectFunction<E, T extends AccessibleObject, R> {
+		R access(E object, T accessibleObject) throws ReflectiveOperationException;
 	}
 
-	private interface AccessibleObjectConsumer<T extends AccessibleObject> {
-		void access(T object) throws ReflectiveOperationException;
+	private interface AccessibleObjectConsumer<E, T extends AccessibleObject> {
+		void access(E object, T accessibleObject) throws ReflectiveOperationException;
 	}
 
-	private static <T extends AccessibleObject> void withAccessibleObject(T accessibleObject, AccessibleObjectConsumer<T> accessibleObjectConsumer) throws ReflectiveOperationException {
-		withAccessibleObject(accessibleObject, obj -> {
-			accessibleObjectConsumer.access(obj);
+	private static <E, T extends AccessibleObject> void withAccessibleObject(E object, T accessibleObject, AccessibleObjectConsumer<E, T> accessibleObjectConsumer) throws ReflectiveOperationException {
+		withAccessibleObject(object, accessibleObject, (obj, accObj) -> {
+			accessibleObjectConsumer.access(obj, accObj);
 			return null;
 		}, true);
 	}
 
-	private static <T extends AccessibleObject, R> R withAccessibleObject(T accessibleObject, AccessibleObjectFunction<T, R> function, boolean force) throws ReflectiveOperationException {
-		boolean accessible = accessibleObject.isAccessible();
+	private static <E, T extends AccessibleObject, R> R withAccessibleObject(E object, T accessibleObject, AccessibleObjectFunction<E, T, R> function, boolean force) throws ReflectiveOperationException {
+		boolean accessible = accessibleObject.canAccess(object);
 		try {
 			if (force && !accessible) {
 				accessibleObject.setAccessible(true);
 			}
-			return function.access(accessibleObject);
+			return function.access(object, accessibleObject);
 		} finally {
 			if (force && !accessible) {
 				accessibleObject.setAccessible(false);

src/main/java/de/cronn/reflection/util/immutable/ImmutableProxy.java

@@ -260,7 +260,7 @@ private static ElementMatcher<MethodDescription> isAnnotatedWith(Class<? extends
 	}
 
 	private static boolean isAnnotatedWith(SignatureToken methodSignature, TypeDefinition type, Class<? extends Annotation> annotation) {
-		if (type == null || type.equals(TypeDescription.OBJECT)) {
+		if (type == null || type.equals(TypeDescription.ForLoadedType.of(Object.class))) {
 			return false;
 		}
 

src/test/java/de/cronn/reflection/util/ClassUtilsTest.java

@@ -351,18 +351,18 @@ void testGetAllDeclaredMethodSignatures() throws Exception {
 
 	@Test
 	void testCreateInstance_AccessibleFlagIsRestored() throws Exception {
-		Constructor<TestEntity> constructor = TestEntity.class.getDeclaredConstructor();
-		assertThat(constructor.isAccessible()).isFalse();
+		Constructor<EntityProtectedConstructor> constructor = EntityProtectedConstructor.class.getDeclaredConstructor();
+		assertThat(constructor.canAccess(null)).isFalse();
 
 		assertThat(ClassUtils.createInstance(constructor)).isNotNull();
 
-		assertThat(constructor.isAccessible()).isFalse();
+		assertThat(constructor.canAccess(null)).isFalse();
 
 		constructor.setAccessible(true);
 
 		assertThat(ClassUtils.createInstance(constructor)).isNotNull();
 
-		assertThat(constructor.isAccessible()).isTrue();
+		assertThat(constructor.canAccess(null)).isTrue();
 	}
 
 	@Test

src/test/java/de/cronn/reflection/util/PropertyUtilsTest.java

@@ -16,11 +16,6 @@
 import java.util.concurrent.Executors;
 import java.util.stream.Collectors;
 
-import jakarta.validation.constraints.NotNull;
-import jakarta.validation.constraints.Size;
-
-import net.bytebuddy.dynamic.DynamicType;
-
 import org.junit.jupiter.api.Test;
 import org.junit.jupiter.api.Timeout;
 import org.mockito.Mockito;
@@ -43,7 +38,10 @@
 import de.cronn.reflection.util.testclasses.SubclassOfClassWithDefaultMethods;
 import de.cronn.reflection.util.testclasses.TestAnnotation;
 import de.cronn.reflection.util.testclasses.TestEntity;
+import jakarta.validation.constraints.NotNull;
+import jakarta.validation.constraints.Size;
 import net.bytebuddy.ByteBuddy;
+import net.bytebuddy.dynamic.DynamicType;
 
 class PropertyUtilsTest {
 
@@ -624,17 +622,17 @@ void testReadDirectly_AccessibilityAfterDirectReadIsRestored() throws Exception
 		PropertyDescriptor property = PropertyUtils.getPropertyDescriptor(TestEntity.class, TestEntity::getNumber);
 
 		Field declaredField = getTestEntityField(property);
-		assertThat(declaredField.isAccessible()).isFalse();
+		assertThat(declaredField.canAccess(testEntity)).isFalse();
 
 		PropertyUtils.readDirectly(testEntity, declaredField);
 
-		assertThat(declaredField.isAccessible()).isFalse();
+		assertThat(declaredField.canAccess(testEntity)).isFalse();
 
 		declaredField.setAccessible(true);
-		assertThat(declaredField.isAccessible()).isTrue();
+		assertThat(declaredField.canAccess(testEntity)).isTrue();
 
 		PropertyUtils.readDirectly(testEntity, declaredField);
-		assertThat(declaredField.isAccessible()).isTrue();
+		assertThat(declaredField.canAccess(testEntity)).isTrue();
 	}
 
 	@Test

src/test/java/de/cronn/reflection/util/TestUtils.java

@@ -11,7 +11,7 @@ private TestUtils() {
 
 	static void assertThatConstructorIsPrivate(Class<?> utilityClass) throws Exception {
 		Constructor<?> constructor = utilityClass.getDeclaredConstructor();
-		assertThat(constructor.isAccessible()).isFalse();
+		assertThat(constructor.canAccess(null)).isFalse();
 		constructor.setAccessible(true);
 		Object instance = constructor.newInstance();
 		assertThat(instance).isNotNull();