-
Notifications
You must be signed in to change notification settings - Fork 1
Open
Labels
chall-managerRelated to chall-managerRelated to chall-managerenhancementNew feature or requestNew feature or requestgoPull requests that update Go codePull requests that update Go codeotelWhen related to OpenTelemetry support.When related to OpenTelemetry support.
Description
Current approach is to sample every trace generated by chall-manager. This is good for developing and debugging, but in reality this is not always interesting.
https://github.com/ctfer-io/chall-manager/blob/main/global/otel.go#L46-L49
OpenTelemetry documentation states the following.
When in a production environment, consider using the
ParentBased
sampler with theTraceIDRatioBased
sampler.
Getting closer to GA, I think it becomes important to consider real production setups.
Metadata
Metadata
Assignees
Labels
chall-managerRelated to chall-managerRelated to chall-managerenhancementNew feature or requestNew feature or requestgoPull requests that update Go codePull requests that update Go codeotelWhen related to OpenTelemetry support.When related to OpenTelemetry support.