chore: address clippy lints within new code

Author: robjtede

ed25519-dalek/src/verifying.rs

@@ -216,29 +216,6 @@ impl VerifyingKey {
         }
     }
 
-    #[allow(non_snake_case)]
-    pub(crate) fn raw_verify_byupdate<CtxDigest, F>(
-        &self,
-        msg_update: F,
-        signature: &ed25519::Signature,
-    ) -> Result<(), SignatureError>
-    where
-        CtxDigest: Digest<OutputSize = U64>,
-        F: FnOnce(&mut CtxDigest) -> Result<(), SignatureError>,
-    {
-        let signature = InternalSignature::try_from(signature)?;
-
-        let mut c = RCompute::<CtxDigest>::new(self, signature, None);
-        msg_update(&mut c.h)?;
-        let expected_R = c.finish();
-
-        if expected_R == signature.R {
-            Ok(())
-        } else {
-            Err(InternalError::Verify.into())
-        }
-    }
-
     /// The prehashed non-batched Ed25519 verification check, rejecting non-canonical R values.
     /// (see [`Self::recompute_R`]). `CtxDigest` is the digest used to calculate the
     /// pseudorandomness needed for signing. `MsgDigest` is the digest used to hash the signed

ed25519-dalek/tests/ed25519.rs

@@ -338,28 +338,25 @@ mod integrations {
     #[test]
     fn sign_verify_digest_equivalence() {
         // TestSignVerify
-        let keypair: SigningKey;
-        let good_sig: Signature;
-        let bad_sig: Signature;
+
+        let mut csprng = OsRng {};
 
         let good: &[u8] = "test message".as_bytes();
         let bad: &[u8] = "wrong message".as_bytes();
 
-        let mut csprng = OsRng {};
-
-        keypair = SigningKey::generate(&mut csprng);
-        good_sig = keypair.sign(&good);
-        bad_sig = keypair.sign(&bad);
+        let keypair: SigningKey = SigningKey::generate(&mut csprng);
+        let good_sig: Signature = keypair.sign(good);
+        let bad_sig: Signature = keypair.sign(bad);
 
         let mut verifier = keypair.verify_stream(&good_sig).unwrap();
-        verifier.update(&good);
+        verifier.update(good);
         assert!(
             verifier.finalize_and_verify().is_ok(),
             "Verification of a valid signature failed!"
         );
 
         let mut verifier = keypair.verify_stream(&bad_sig).unwrap();
-        verifier.update(&good);
+        verifier.update(good);
         assert!(
             verifier.finalize_and_verify().is_err(),
             "Verification of a signature on a different message passed!"
@@ -374,7 +371,7 @@ mod integrations {
         );
 
         let mut verifier = keypair.verify_stream(&good_sig).unwrap();
-        verifier.update(&bad);
+        verifier.update(bad);
         assert!(
             verifier.finalize_and_verify().is_err(),
             "Verification of a signature on a different message passed!"