chore: revert raw_sign

Author: robjtede

ed25519-dalek/src/signing.rs

@@ -833,7 +833,6 @@ impl ExpandedSecretKey {
     /// This definition is loose in its parameters so that end-users of the `hazmat` module can
     /// change how the `ExpandedSecretKey` is calculated and which hash function to use.
     #[allow(non_snake_case)]
-    #[allow(clippy::unwrap_used)]
     #[inline(always)]
     pub(crate) fn raw_sign<CtxDigest>(
         &self,
@@ -842,48 +841,24 @@ impl ExpandedSecretKey {
     ) -> Signature
     where
         CtxDigest: Digest<OutputSize = U64>,
-    {
-        // OK unwrap, update can't fail.
-        self.raw_sign_byupdate(
-            |h: &mut CtxDigest| {
-                h.update(message);
-                Ok(())
-            },
-            verifying_key,
-        )
-        .unwrap()
-    }
-
-    /// Sign a message provided in parts. The `msg_update` closure
-    /// will be called twice to hash the message parts.
-    #[allow(non_snake_case)]
-    #[inline(always)]
-    pub(crate) fn raw_sign_byupdate<CtxDigest, F>(
-        &self,
-        msg_update: F,
-        verifying_key: &VerifyingKey,
-    ) -> Result<Signature, SignatureError>
-    where
-        CtxDigest: Digest<OutputSize = U64>,
-        F: Fn(&mut CtxDigest) -> Result<(), SignatureError>,
     {
         let mut h = CtxDigest::new();
 
         h.update(self.hash_prefix);
-        msg_update(&mut h)?;
+        h.update(message);
 
         let r = Scalar::from_hash(h);
         let R: CompressedEdwardsY = EdwardsPoint::mul_base(&r).compress();
 
         h = CtxDigest::new();
         h.update(R.as_bytes());
         h.update(verifying_key.as_bytes());
-        msg_update(&mut h)?;
+        h.update(message);
 
         let k = Scalar::from_hash(h);
         let s: Scalar = (k * self.scalar) + r;
 
-        Ok(InternalSignature { R, s }.into())
+        InternalSignature { R, s }.into()
     }
 
     /// The prehashed signing function for Ed25519 (i.e., Ed25519ph). `CtxDigest` is the digest