Skip to content

Commit 46f8634

Browse files
committed
Cleanup TODOs, tests etc.
1 parent 0354f52 commit 46f8634

File tree

5 files changed

+2
-11
lines changed

5 files changed

+2
-11
lines changed

examples/stack/cube.py

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -3,10 +3,6 @@
33

44
import classy_blocks as cb
55

6-
# TODO! direct imports
7-
from classy_blocks.construct.flat.sketches.grid import Grid
8-
from classy_blocks.construct.stack import ExtrudedStack
9-
106
# cube side;
117
# it sits in the coordinate system origin
128
# (center of the cube is [0, 0, side/2])
@@ -28,9 +24,9 @@
2824
point_1 = [-1.5 * side, -1.5 * side, 0]
2925
point_2 = [1.5 * side, 1.5 * side, 0]
3026

31-
base = Grid(point_1, point_2, 3, 3)
27+
base = cb.Grid(point_1, point_2, 3, 3)
3228

33-
stack = ExtrudedStack(base, side * 2, 2)
29+
stack = cb.ExtrudedStack(base, side * 2, 2)
3430

3531
# add all blocks to mesh
3632
mesh.add(stack)

src/classy_blocks/construct/flat/face.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -159,7 +159,6 @@ def project(self, label: str, edges: bool = False, points: bool = False) -> None
159159
in Mesh object."""
160160
self.projected_to = label
161161

162-
# TODO: TEST
163162
if edges:
164163
for i in range(4):
165164
self.project_edge(i, label)

src/classy_blocks/construct/operations/operation.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -228,7 +228,6 @@ def get_all_faces(self) -> Dict[OrientType, Face]:
228228

229229
def get_closest_side(self, point: PointType) -> OrientType:
230230
"""Returns side (bottom/top/left/right/front/back) of the closest face to given point"""
231-
# TODO: TEST
232231
point = np.array(point)
233232
all_faces = self.get_all_faces()
234233
sides = list(all_faces.keys())
@@ -239,7 +238,6 @@ def get_closest_side(self, point: PointType) -> OrientType:
239238

240239
def get_closest_face(self, point: PointType) -> Face:
241240
"""Returns a Face that has a center nearest to given point"""
242-
# TODO: TEST
243241
return self.get_face(self.get_closest_side(point))
244242

245243
def get_normal_face(self, point: PointType) -> Face:

src/classy_blocks/optimize/optimizer.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,6 @@ def add_link(self, link: LinkBase) -> None:
3939
def optimize_clamp(self, clamp: ClampBase, method: MinimizationMethodType) -> None:
4040
"""Move clamp.vertex so that quality at junction is improved;
4141
rollback changes if grid quality decreased after optimization"""
42-
# TODO! do something with this updating/rollback junk
4342
initial_params = copy.copy(clamp.params)
4443
junction = self.grid.get_junction_from_clamp(clamp)
4544

src/classy_blocks/types.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@
1717

1818
# parametric curve
1919
ParamCurveFuncType = Callable[[float], NPPointType]
20-
ParamCurveListType = NDArray[Shape["3, *"], Any] # TODO: really necessary?
2120

2221
# edge kinds as per blockMesh's definition
2322
EdgeKindType = Literal["line", "arc", "origin", "angle", "spline", "polyLine", "project", "curve"]

0 commit comments

Comments
 (0)