Merge pull request #521 from damongolding/chore/better-field-alignment

Chore/better field alignment

Author: damongolding

config.schema.json

@@ -17,7 +17,11 @@
       "type": "boolean"
     },
     "time_format": {
-      "type": ["integer", "string"]
+      "oneOf": [
+        { "type": "string", "enum": ["12", "24"] },
+        { "type": "integer", "enum": [12, 24] }
+      ],
+      "examples": ["12", "24"]
     },
     "show_date": {
       "type": "boolean"
@@ -47,7 +51,8 @@
       "type": ["string", "array"],
       "items": {
         "type": "string"
-      }
+      },
+      "uniqueItems": true
     },
     "require_all_people": {
       "type": "boolean"
@@ -56,13 +61,15 @@
       "type": ["string", "array"],
       "items": {
         "type": "string"
-      }
+      },
+      "uniqueItems": true
     },
     "albums": {
       "type": ["string", "array"],
       "items": {
         "type": "string"
-      }
+      },
+      "uniqueItems": true
     },
     "album_video": {
       "type": "boolean"
@@ -74,19 +81,22 @@
       "type": ["string", "array"],
       "items": {
         "type": "string"
-      }
+      },
+      "uniqueItems": true
     },
     "dates": {
       "type": ["string", "array"],
       "items": {
         "type": "string"
-      }
+      },
+      "uniqueItems": true
     },
     "tags": {
       "type": ["string", "array"],
       "items": {
         "type": "string"
-      }
+      },
+      "uniqueItems": true
     },
     "memories": {
       "type": "boolean"
@@ -200,7 +210,11 @@
       "type": "boolean"
     },
     "image_time_format": {
-      "type": ["integer", "string"]
+      "oneOf": [
+        { "type": "string", "enum": ["12", "24"] },
+        { "type": "integer", "enum": [12, 24] }
+      ],
+      "examples": ["12", "24"]
     },
     "show_image_date": {
       "type": "boolean"
@@ -224,7 +238,8 @@
       "type": ["string", "array"],
       "items": {
         "type": "string"
-      }
+      },
+      "uniqueItems": true
     },
     "show_image_id": {
       "type": "boolean"
@@ -242,13 +257,15 @@
       "type": ["string", "array"],
       "items": {
         "type": "string"
-      }
+      },
+      "uniqueItems": true
     },
     "hide_button_action": {
       "type": ["string", "array"],
       "items": {
         "type": "string"
-      }
+      },
+      "uniqueItems": true
     },
     "weather": {
       "type": "array",
@@ -307,13 +324,15 @@
       "type": "array",
       "items": {
         "type": "string"
-      }
+      },
+      "uniqueItems": true
     },
     "iframe": {
       "type": ["string", "array"],
       "items": {
         "type": "string"
-      }
+      },
+      "uniqueItems": true
     },
     "immich_users_api_keys": {
       "type": "object",
@@ -329,7 +348,8 @@
       "type": ["string", "array"],
       "items": {
         "type": "string"
-      }
+      },
+      "uniqueItems": true
     },
     "show_user": {
       "type": "boolean"
@@ -373,9 +393,9 @@
         },
         "config_validation_level": {
           "type": "string",
-          "enum": ["warning", "error"],
+          "enum": ["warning", "error", "off"],
           "default": "error",
-          "description": "Controls how invalid configuration is handled. 'warning' logs a warning and continues; 'error' treats invalid configuration as fatal."
+          "description": "Controls how invalid configuration is handled. 'warning' logs a warning and continues; 'error' treats invalid configuration as fatal; 'off' disables validation checks."
         },
         "port": {
           "type": "integer"
@@ -387,7 +407,9 @@
           "type": "boolean"
         },
         "fetched_assets_size": {
-          "type": "integer"
+          "type": "integer",
+          "minimum": 1,
+          "maximum": 1000
         },
         "http_timeout": {
           "type": "integer"

internal/common/common.go

@@ -76,20 +76,20 @@ func (c *Common) Secret() string {
 
 // RouteRequestData contains request metadata and configuration used across routes
 type RouteRequestData struct {
-	RequestConfig config.Config // Configuration for the current request
 	DeviceID      string        // Unique identifier for the device making the request
 	RequestID     string        // Unique identifier for this specific request
 	ClientName    string        // Name of the client making the request
+	RequestConfig config.Config // Configuration for the current request
 }
 
 // ViewImageData contains the image data and metadata for displaying an image in the view
 type ViewImageData struct {
-	ImmichAsset        immich.Asset // ImmichAsset contains immich asset data
 	ImageData          string       // ImageData contains the image as base64 data
 	ImageBlurData      string       // ImageBlurData contains the blurred image as base64 data
-	ImageDominantColor color.RGBA   // ImageDominantColor contains the dominant color of the image
 	ImageDate          string       // ImageDate contains the date of the image
 	User               string       // User the user api key used
+	ImmichAsset        immich.Asset // ImmichAsset contains immich asset data
+	ImageDominantColor color.RGBA   // ImageDominantColor contains the dominant color of the image
 }
 
 // ViewData contains all the data needed to render a view in the application
@@ -104,17 +104,17 @@ type ViewData struct {
 }
 
 type ViewImageDataOptions struct {
-	RelativeAssetWanted   bool
 	RelativeAssetBucket   kiosk.Source
 	RelativeAssetBucketID string
 	ImageOrientation      immich.ImageOrientation
+	RelativeAssetWanted   bool
 }
 
 // ContextCopy stores a copy of key HTTP context information including URL and headers
 type ContextCopy struct {
-	URL            url.URL     // The request URL
 	RequestHeader  http.Header // Headers from the incoming request
 	ResponseHeader http.Header // Headers for the outgoing response
+	URL            url.URL     // The request URL
 }
 
 // CopyContext creates a copy of essential context data from an echo.Context