Merge pull request #1647 from ksylvan/0725-fix-release-workflow-race-condition

Simplify Workflow with Single Version Retrieval Step

Author: ksylvan

.github/workflows/release.yml

@@ -93,19 +93,24 @@ jobs:
           name: fabric-windows-${{ matrix.arch }}.exe
           path: fabric-windows-${{ matrix.arch }}.exe
 
-      - name: Get latest tag
-        if: matrix.os != 'windows-latest'
-        id: get_latest_tag
-        run: |
-          latest_tag=$(git tag --sort=-creatordate | head -n 1)
-          echo "latest_tag=$latest_tag" >> $GITHUB_ENV
-
-      - name: Get latest tag
-        if: matrix.os == 'windows-latest'
-        id: get_latest_tag_windows
+      - name: Get version from source
+        id: get_version
+        shell: bash
         run: |
-          $latest_tag = git tag --sort=-creatordate | Select-Object -First 1
-          Add-Content -Path $env:GITHUB_ENV -Value "latest_tag=$latest_tag"
+          if [ ! -f "nix/pkgs/fabric/version.nix" ]; then
+            echo "Error: version.nix file not found"
+            exit 1
+          fi
+          version=$(cat nix/pkgs/fabric/version.nix | tr -d '"' | tr -cd '0-9.')
+          if [ -z "$version" ]; then
+            echo "Error: version is empty"
+            exit 1
+          fi
+          if ! echo "$version" | grep -E '^[0-9]+\.[0-9]+\.[0-9]+' > /dev/null; then
+            echo "Error: Invalid version format: $version"
+            exit 1
+          fi
+          echo "latest_tag=v$version" >> $GITHUB_ENV
 
       - name: Create release if it doesn't exist
         shell: bash

cmd/generate_changelog/incoming/1647.txt

@@ -0,0 +1,7 @@
+### PR [#1647](https://github.com/danielmiessler/Fabric/pull/1647) by [ksylvan](https://github.com/ksylvan): Simplify Workflow with Single Version Retrieval Step
+
+- Replace git tag lookup with version.nix file reading for release workflow
+- Remove OS-specific git tag retrieval steps and add unified version extraction from nix file
+- Include version format validation with regex check
+- Add error handling for missing version file
+- Consolidate cross-platform version logic into single step with bash shell for consistent version parsing