Skip to content

Commit 0af4aae

Browse files
authored
Implemented show\hide kernel progress bar for Output (#274)
* Implemented show\hide kernel progress bar for Output Kernel progress bar visible by default when kernel is not idle looks very strange. In fact when we execute just one output - EVERY output on the page shows some progress which seems very strange and misleading for me, because I triggered execution of only one specific output Another issue with this progress bar is it shows progress when kernel is not executing anything AND is not 'idle'. I guess in that state kernel tries to initialize or smth like this but user is seeing some progress which also looks misleading for me * Added default true for showKernelProgressBar
1 parent def8c43 commit 0af4aae

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

packages/react/src/components/output/Output.tsx

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,7 @@ export type IOutputProps = {
3737
receipt?: string;
3838
showControl?: boolean;
3939
showEditor: boolean;
40+
showKernelProgressBar?: boolean;
4041
sourceId: string;
4142
toolbarPosition: 'up' | 'middle' | 'none';
4243
};
@@ -58,6 +59,7 @@ export const Output = (props: IOutputProps) => {
5859
receipt,
5960
showControl,
6061
showEditor,
62+
showKernelProgressBar = true,
6163
sourceId,
6264
toolbarPosition,
6365
} = props;
@@ -166,7 +168,7 @@ export const Output = (props: IOutputProps) => {
166168
{adapter && (
167169
<Box display="flex">
168170
<Box flexGrow={1}>
169-
{kernelStatus !== 'idle' && <KernelProgressBar />}
171+
{kernelStatus !== 'idle' && showKernelProgressBar && <KernelProgressBar />}
170172
</Box>
171173
{showControl && (
172174
<Box style={{ marginTop: '-13px' }}>

0 commit comments

Comments
 (0)