fix: reject promise error cases in onReply (#279)

Author: Marcos Alves

packages/react/src/components/cell/CellAdapter.ts

@@ -485,6 +485,7 @@ export class CellAdapter {
       cellsStore.getState().setIsExecuting(this._id, false);
       return executeReplyMessage;
     } catch (e) {
+      cellsStore.getState().setIsExecuting(this._id, false);
       // If we started executing, and the cell is still indicating this execution, clear the prompt.
       if (future && !cell.isDisposed && cell.outputArea.future === future) {
         cell.setPrompt('');
@@ -498,7 +499,6 @@ export class CellAdapter {
           model.setMetadata('execution', timingInfo);
         }
       }
-      cellsStore.getState().setIsExecuting(this._id, false);
       throw e;
     }
   }

packages/react/src/examples/CellExecuteControl.tsx

@@ -22,10 +22,7 @@ const btnStyle = {
     marginTop: '20px'
 }
 
-const CELL_CODE = `
-import time
-time.sleep(10)
-`
+const CELL_CODE = `import time\ntime.sleep(3)`
 
 const CellExecuteControl = () => {
   const [executionDisable, setExecutionDisable] = React.useState(false);
@@ -50,13 +47,13 @@ const CellExecuteControl = () => {
       <Box style={{marginTop: '20px'}}>
         <Cell 
           id='1' 
-          type={'code'} 
+          type='code'
           source={CELL_CODE} 
           autoStart={false} 
           showToolbar={false} />
         <Cell 
           id='2' 
-          type={'code'} 
+          type='code'
           autoStart={false} 
           showToolbar={false} />
         <Button 

packages/react/src/jupyter/kernel/KernelExecutor.ts

@@ -258,11 +258,13 @@ export class KernelExecutor {
           break;
         case 'error':
           {
-            const { ename, evalue, traceback } = (
-              content as any as KernelMessage.IErrorMsg
-            ).content;
+            // NOTE: This block that was here previously cannot extract the properties consistently, 
+            //causing the Promise to never be rejected in case of an execution error.
+            // const { ename, evalue, traceback } = (
+            //   content as any as KernelMessage.IErrorMsg
+            // ).content;
             this._executed.reject(
-              `${ename}: ${evalue}\n${(traceback ?? []).join('\n')}`
+              `${content.ename}: ${content.evalue}\n${(content.traceback ?? []).join('\n')}`
             );
           }
           break;