Skip to content

Commit d1ae32a

Browse files
author
Marcos Alves
committed
feat: improve isKernelSession prop naming (#273)
1 parent 617dccc commit d1ae32a

File tree

2 files changed

+15
-15
lines changed

2 files changed

+15
-15
lines changed

packages/react/src/components/cell/CellState.ts

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -12,33 +12,33 @@ export interface ICellState {
1212
source?: string;
1313
outputsCount?: number;
1414
adapter?: CellAdapter;
15-
kernelAvailable?: boolean;
15+
isKernelSessionAvailable?: boolean; // Individual, for cell
1616
}
1717

1818
export interface ICellsState {
1919
cells: Map<string, ICellState>;
20-
areAllCellsReady: boolean;
20+
areAllKernelSessionsReady: boolean; // Control the state for all cells
2121
}
2222

2323
export type CellState = ICellsState & {
2424
setCells: (cells: Map<string, ICellState>) => void;
2525
setSource: (id: string, source: string) => void;
2626
setOutputsCount: (id: string, outputsCount: number) => void;
27-
setKernelAvailable: (id: string, kernelAvailable: boolean) => void;
27+
setIsKernelSessionAvailable: (id: string, kernelAvailable: boolean) => void;
2828
setAdapter: (id: string, adapter?: CellAdapter) => void;
2929
getAdapter: (id: string) => CellAdapter | undefined;
3030
getSource: (id: string) => string | undefined;
3131
getOutputsCount: (id: string) => number | undefined;
32-
getIsKernelAvailable: (id: string) => boolean | undefined;
32+
getIsKernelSessionAvailable: (id: string) => boolean | undefined;
3333
execute: (id?: string) => void;
3434
};
3535

3636
/**
3737
* Iterate over all cells map and check if all cells/sessions are ready
3838
*/
39-
const areAllSessionsAvailable = (cells: Map<string, ICellState>): boolean => {
39+
const areAllKernelSessionsAvailable = (cells: Map<string, ICellState>): boolean => {
4040
for (const cell of cells.values()) {
41-
if (!cell.kernelAvailable) {
41+
if (!cell.isKernelSessionAvailable) {
4242
return false;
4343
}
4444
}
@@ -49,8 +49,8 @@ export const cellStore = createStore<CellState>((set, get) => ({
4949
cells: new Map<string, ICellState>(),
5050
source: '',
5151
outputsCount: 0,
52-
kernelAvailable: false,
53-
areAllCellsReady: false,
52+
isKernelSessionAvailable: false,
53+
areAllKernelSessionsReady: false,
5454
adapter: undefined,
5555
setCells: (cells: Map<string, ICellState>) => set((cell: CellState) => ({ cells })),
5656

@@ -74,15 +74,15 @@ export const cellStore = createStore<CellState>((set, get) => ({
7474
}
7575
set((state: CellState) => ({ cells }))
7676
},
77-
setKernelAvailable: (id: string, kernelAvailable: boolean) => {
77+
setIsKernelSessionAvailable: (id: string, isKernelSessionAvailable: boolean) => {
7878
const cells = get().cells;
7979
const cell = cells.get(id);
8080
if (cell) {
81-
cell.kernelAvailable = kernelAvailable;
81+
cell.isKernelSessionAvailable = isKernelSessionAvailable;
8282
} else {
83-
cells.set(id, {kernelAvailable});
83+
cells.set(id, {isKernelSessionAvailable});
8484
}
85-
const areAllCellsReady = areAllSessionsAvailable(cells);
85+
const areAllCellsReady = areAllKernelSessionsAvailable(cells);
8686
set((cell: CellState) => ({ cells, areAllCellsReady }));
8787
},
8888
setAdapter: (id: string, adapter?: CellAdapter) => {
@@ -104,8 +104,8 @@ export const cellStore = createStore<CellState>((set, get) => ({
104104
getOutputsCount: (id: string): number | undefined => {
105105
return get().cells.get(id)?.outputsCount;
106106
},
107-
getIsKernelAvailable: (id: string): boolean | undefined => {
108-
return get().cells.get(id)?.kernelAvailable;
107+
getIsKernelSessionAvailable: (id: string): boolean | undefined => {
108+
return get().cells.get(id)?.isKernelSessionAvailable;
109109
},
110110
execute: (id: string) => {
111111
const cells = get().cells;

packages/react/src/examples/All.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ const CellPreview = (props: ICellToolProps) => {
5858
return (
5959
<>
6060
<>source: {cellStore.getSource(props.id)}</>
61-
<>kernel available: {String(cellStore.getIsKernelAvailable(props.id))}</>
61+
<>kernel available: {String(cellStore.getIsKernelSessionAvailable(props.id))}</>
6262
</>
6363
);
6464
};

0 commit comments

Comments
 (0)