File tree Expand file tree Collapse file tree 3 files changed +0
-9
lines changed
packages/react/src/components/lumino Expand file tree Collapse file tree 3 files changed +0
-9
lines changed Original file line number Diff line number Diff line change 5
5
*/
6
6
7
7
import { useRef , useEffect } from 'react' ;
8
- import { unmountComponentAtNode } from 'react-dom' ;
9
8
import { Widget } from '@lumino/widgets' ;
10
9
11
10
type LuminoProps = {
@@ -26,7 +25,6 @@ export const Lumino = (props: LuminoProps) => {
26
25
}
27
26
return ( ) => {
28
27
try {
29
- unmountComponentAtNode ( children . node ) ;
30
28
if ( children . isAttached || children . node . isConnected ) {
31
29
children . dispose ( ) ;
32
30
Widget . detach ( children ) ;
Original file line number Diff line number Diff line change 5
5
*/
6
6
7
7
import { useRef , useEffect } from 'react' ;
8
- import { unmountComponentAtNode } from 'react-dom' ;
9
8
import { Widget , BoxPanel } from '@lumino/widgets' ;
10
9
import { Box } from '@primer/react' ;
11
10
@@ -30,7 +29,6 @@ export const LuminoBox = (props: LuminoBoxProps) => {
30
29
}
31
30
return ( ) => {
32
31
try {
33
- unmountComponentAtNode ( boxPanel . node ) ;
34
32
if ( boxPanel . isAttached || boxPanel . node . isConnected ) {
35
33
boxPanel . dispose ( ) ;
36
34
Widget . detach ( boxPanel ) ;
Original file line number Diff line number Diff line change @@ -54,11 +54,6 @@ export abstract class ReactPortalWidget extends Widget {
54
54
*/
55
55
protected onBeforeDetach ( msg : Message ) : void {
56
56
// Unmount the component so it can tear down.
57
- // TODO unmountComponentAtNode or not?
58
- // console.js:213 Warning: unmountComponentAtNode():
59
- // The node you're attempting to unmount was rendered by React and is not a top-level container.
60
- // Instead, have the parent component update its state and rerender in order to remove this component.
61
- // ReactDOM.unmountComponentAtNode(this.node);
62
57
}
63
58
64
59
/**
You can’t perform that action at this time.
0 commit comments