feat: Rename self_reporting to send_statistics

Author: Hocuri

src/main/java/org/thoughtcrime/securesms/connect/DcHelper.java

@@ -75,7 +75,7 @@ public class DcHelper {
     public static final String CONFIG_VERIFIED_ONE_ON_ONE_CHATS = "verified_one_on_one_chats";
     public static final String CONFIG_WEBXDC_REALTIME_ENABLED = "webxdc_realtime_enabled";
     public static final String CONFIG_PRIVATE_TAG = "private_tag";
-    public static final String CONFIG_SELF_REPORTING = "self_reporting";
+    public static final String CONFIG_SEND_STATISTICS = "send_statistics";
 
     public static DcContext getContext(@NonNull Context context) {
         return ApplicationContext.getInstance(context).dcContext;

src/main/java/org/thoughtcrime/securesms/preferences/AdvancedPreferenceFragment.java

@@ -5,7 +5,7 @@
 import static org.thoughtcrime.securesms.connect.DcHelper.CONFIG_BCC_SELF;
 import static org.thoughtcrime.securesms.connect.DcHelper.CONFIG_MVBOX_MOVE;
 import static org.thoughtcrime.securesms.connect.DcHelper.CONFIG_ONLY_FETCH_MVBOX;
-import static org.thoughtcrime.securesms.connect.DcHelper.CONFIG_SELF_REPORTING;
+import static org.thoughtcrime.securesms.connect.DcHelper.CONFIG_SEND_STATISTICS;
 import static org.thoughtcrime.securesms.connect.DcHelper.CONFIG_SENTBOX_WATCH;
 import static org.thoughtcrime.securesms.connect.DcHelper.CONFIG_SHOW_EMAILS;
 import static org.thoughtcrime.securesms.connect.DcHelper.CONFIG_WEBXDC_REALTIME_ENABLED;
@@ -215,11 +215,11 @@ public void onCreate(Bundle paramBundle) {
       });
     }
 
-    selfReportingCheckbox = this.findPreference("pref_self_reporting");
+    selfReportingCheckbox = this.findPreference("pref_send_statistics");
     if (selfReportingCheckbox != null) {
       selfReportingCheckbox.setOnPreferenceChangeListener((preference, newValue) -> {
         boolean enabled = (Boolean) newValue;
-        dcContext.setConfigInt(CONFIG_SELF_REPORTING, enabled? 1 : 0);
+        dcContext.setConfigInt(CONFIG_SEND_STATISTICS, enabled? 1 : 0);
 
         if (enabled) {
           new AlertDialog.Builder(getActivity())
@@ -276,7 +276,7 @@ public void onResume() {
     updateListSummary(showEmails, value);
 
     sentboxWatchCheckbox.setChecked(0!=dcContext.getConfigInt(CONFIG_SENTBOX_WATCH));
-    selfReportingCheckbox.setChecked(0!=dcContext.getConfigInt(CONFIG_SELF_REPORTING));
+    selfReportingCheckbox.setChecked(0!=dcContext.getConfigInt(CONFIG_SEND_STATISTICS));
     bccSelfCheckbox.setChecked(0!=dcContext.getConfigInt(CONFIG_BCC_SELF));
     mvboxMoveCheckbox.setChecked(0!=dcContext.getConfigInt(CONFIG_MVBOX_MOVE));
     onlyFetchMvboxCheckbox.setChecked(0!=dcContext.getConfigInt(CONFIG_ONLY_FETCH_MVBOX));

src/main/res/xml/preferences_advanced.xml

@@ -13,7 +13,7 @@
 
     <org.thoughtcrime.securesms.components.SwitchPreferenceCompat
         android:defaultValue="false"
-        android:key="pref_self_reporting"
+        android:key="pref_send_statistics"
         android:title="@string/send_stats_to_devs"
         android:summary="@string/send_stats_to_devs_explanation"/>