Remove duplicate from the search suggestion list

[MizukiTemma]

Describe the Bug

A case was found where a search keyword is suggested more than once.

Steps to Reproduce

1. Create a new contact
2. Give to the field "Name" the same name with the selected location (ex: select a location "Test-ort", put "Test-ort" to the "name" field of the contact form)
3. Save
4. Go to the contact list
5. Type in the search findow "Test"
6. See two suggstions for "Test-ort"

Expected Behavior

"Test-ort" is suggested only once

Actual Behavior

Twice suggested

Screenshot

Additional Information

This is because we search for both name of contact objects and that of location objects. Because there is a contact with name "Test-ort" (which is containing "Test"), "Test-ort" is added to the suggestion list. There is also a location with name "Test-ort". Here occurs another match, the keyword "Test-ort" is again added to the suggestion list. Now we have two "Test-ort" in the suggestion list.

There may be another model which can experience the same duplication. Check not only for contact, but also for other models.

Traceback

Related Issues

Summary of discussion and updates to the description

[MizukiTemma]

There may be another model which can experience the same duplication. Check not only for contact, but also for other models

So far as I checked, it's only contact and media library.

For contact it goes simple: just omit duplicates, as all the entries have "type": "contact"

integreat-cms/integreat_cms/cms/models/contact/contact.py

Lines 157 to 181 in 7541922

	results.extend(
	{
	"title": contact.name,
	"url": None,
	"type": "contact",
	}
	for contact in cls.objects.filter(
	name__icontains=query,
	location__region=region,
	archived=archived_flag,
	).distinct()
	)
	if language_slug:
	results.extend(
	{
	"title": poi_translation.title,
	"url": None,
	"type": "contact",
	}
	for poi_translation in POITranslation.search(
	region, language_slug, query
	).filter(poi__archived=False)
	)
	return results

For media objects I have a question: are "type": "contact" and "type": "directory" being used somewhere? I don't find any codes using it but would like to double check.
If they are not used anywhere, we can unify all the suggestion for the media search with "type": "media" or something and remove duplicates as for contacts.

integreat-cms/integreat_cms/cms/models/media/media_file.py

Lines 396 to 412 in 7541922

	results.extend(
	{
	"title": file.name,
	"url": None,
	"type": "file",
	}
	for file in cls.search(region, query)
	)
	results.extend(
	{
	"title": directory.name,
	"url": None,
	"type": "directory",
	}
	for directory in Directory.search(region, query)
	)
	return results

[MizukiTemma]

In the originally reported case, more than one models were used as search sourse. Duplicate can appear however even search is made from one single model. There is often no unique constraint to title ot name. If there are more than one objects of the same model with same name or title, duplicated suggestions appear in the search window, even if the search is not checking other (related) models.

🔴 duplicates possible
Event
Feedback
Language
Page
Location
Push notification
Region

✅no duplicates
Organization: the form checkes for unique name.
User: Fist name and last name are not always unique. But username, which is given as suggestion in search, is unique.