Skip to content

Commit 5724494

Browse files
Updates request log plugins to consider URLs to watch. Closes #1081 (#1084)
1 parent 7996e04 commit 5724494

12 files changed

+36
-8
lines changed

dev-proxy-plugins/RequestLogs/ApiCenterMinimalPermissionsPlugin.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -95,6 +95,7 @@ private async Task AfterRecordingStopAsync(object sender, RecordingArgs e)
9595
l.MessageType == MessageType.InterceptedRequest &&
9696
!l.Message.StartsWith("OPTIONS") &&
9797
l.Context?.Session is not null &&
98+
ProxyUtils.MatchesUrlToWatch(UrlsToWatch, l.Context.Session.HttpClient.Request.RequestUri.AbsoluteUri) &&
9899
l.Context.Session.HttpClient.Request.Headers.Any(h => h.Name.Equals("authorization", StringComparison.OrdinalIgnoreCase))
99100
);
100101
if (!interceptedRequests.Any())

dev-proxy-plugins/RequestLogs/ApiCenterOnboardingPlugin.cs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -118,7 +118,8 @@ private async Task AfterRecordingStopAsync(object sender, RecordingArgs e)
118118
var methodAndUrl = request.Message.Split(' ');
119119
return (method: methodAndUrl[0], url: methodAndUrl[1]);
120120
})
121-
.Where(r => !r.method.Equals("OPTIONS", StringComparison.OrdinalIgnoreCase))
121+
.Where(r => !r.method.Equals("OPTIONS", StringComparison.OrdinalIgnoreCase) &&
122+
ProxyUtils.MatchesUrlToWatch(UrlsToWatch, r.url))
122123
.Distinct();
123124

124125
var existingApis = new List<ApiCenterOnboardingPluginReportExistingApiInfo>();

dev-proxy-plugins/RequestLogs/ApiCenterProductionVersionPlugin.cs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,8 @@ private async Task AfterRecordingStopAsync(object sender, RecordingArgs e)
9090
var interceptedRequests = e.RequestLogs
9191
.Where(
9292
l => l.MessageType == MessageType.InterceptedRequest &&
93-
l.Context?.Session is not null
93+
l.Context?.Session is not null &&
94+
ProxyUtils.MatchesUrlToWatch(UrlsToWatch, l.Context.Session.HttpClient.Request.RequestUri.AbsoluteUri)
9495
);
9596
if (!interceptedRequests.Any())
9697
{

dev-proxy-plugins/RequestLogs/GraphMinimalPermissionsGuidancePlugin.cs

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -94,6 +94,12 @@ private async Task AfterRecordingStopAsync(object? sender, RecordingArgs e)
9494
{
9595
continue;
9696
}
97+
98+
if (!ProxyUtils.MatchesUrlToWatch(UrlsToWatch, methodAndUrl.url))
99+
{
100+
Logger.LogDebug("URL not matched: {url}", methodAndUrl.url);
101+
continue;
102+
}
97103

98104
var requestsFromBatch = Array.Empty<(string method, string url)>();
99105

dev-proxy-plugins/RequestLogs/GraphMinimalPermissionsPlugin.cs

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -64,6 +64,12 @@ private async Task AfterRecordingStopAsync(object? sender, RecordingArgs e)
6464
continue;
6565
}
6666

67+
if (!ProxyUtils.MatchesUrlToWatch(UrlsToWatch, methodAndUrl.url))
68+
{
69+
Logger.LogDebug("URL not matched: {url}", methodAndUrl.url);
70+
continue;
71+
}
72+
6773
var uri = new Uri(methodAndUrl.url);
6874
if (!ProxyUtils.IsGraphUrl(uri))
6975
{

dev-proxy-plugins/RequestLogs/HttpFileGeneratorPlugin.cs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -139,7 +139,8 @@ private async Task<HttpFile> GetHttpRequestsAsync(IEnumerable<RequestLog> reques
139139
{
140140
if (request.MessageType != MessageType.InterceptedResponse ||
141141
request.Context is null ||
142-
request.Context.Session is null)
142+
request.Context.Session is null ||
143+
!ProxyUtils.MatchesUrlToWatch(UrlsToWatch, request.Context.Session.HttpClient.Request.RequestUri.AbsoluteUri))
143144
{
144145
continue;
145146
}

dev-proxy-plugins/RequestLogs/MinimalCsomPermissionsPlugin.cs

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,6 @@ private async Task AfterRecordingStopAsync(object sender, RecordingArgs e)
7474
.Where(l =>
7575
l.MessageType == MessageType.InterceptedRequest &&
7676
l.Message.StartsWith("POST") &&
77-
l.Message.Contains(".sharepoint.com", StringComparison.InvariantCultureIgnoreCase) &&
7877
l.Message.Contains("/_vti_bin/client.svc/ProcessQuery", StringComparison.InvariantCultureIgnoreCase)
7978
);
8079
if (!interceptedRequests.Any())
@@ -95,6 +94,12 @@ private async Task AfterRecordingStopAsync(object sender, RecordingArgs e)
9594
continue;
9695
}
9796

97+
if (!ProxyUtils.MatchesUrlToWatch(UrlsToWatch, request.Context.Session.HttpClient.Request.RequestUri.AbsoluteUri))
98+
{
99+
Logger.LogDebug("URL not matched: {url}", request.Context.Session.HttpClient.Request.RequestUri.AbsoluteUri);
100+
continue;
101+
}
102+
98103
var requestBody = await request.Context.Session.GetRequestBodyAsString();
99104
if (string.IsNullOrEmpty(requestBody))
100105
{

dev-proxy-plugins/RequestLogs/MinimalPermissionsGuidancePlugin.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -71,6 +71,7 @@ private async Task AfterRecordingStopAsync(object sender, RecordingArgs e)
7171
l.MessageType == MessageType.InterceptedRequest &&
7272
!l.Message.StartsWith("OPTIONS") &&
7373
l.Context?.Session is not null &&
74+
ProxyUtils.MatchesUrlToWatch(UrlsToWatch, l.Context.Session.HttpClient.Request.RequestUri.AbsoluteUri) &&
7475
l.Context.Session.HttpClient.Request.Headers.Any(h => h.Name.Equals("authorization", StringComparison.OrdinalIgnoreCase))
7576
);
7677
if (!interceptedRequests.Any())

dev-proxy-plugins/RequestLogs/MinimalPermissionsPlugin.cs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,8 @@ private async Task AfterRecordingStopAsync(object sender, RecordingArgs e)
6868
.Where(l =>
6969
l.MessageType == MessageType.InterceptedRequest &&
7070
!l.Message.StartsWith("OPTIONS") &&
71-
l.Context?.Session is not null
71+
l.Context?.Session is not null &&
72+
ProxyUtils.MatchesUrlToWatch(UrlsToWatch, l.Context.Session.HttpClient.Request.RequestUri.AbsoluteUri)
7273
);
7374
if (!interceptedRequests.Any())
7475
{

dev-proxy-plugins/RequestLogs/MockGeneratorPlugin.cs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,8 @@ private async Task AfterRecordingStopAsync(object? sender, RecordingArgs e)
3939
{
4040
if (request.MessageType != MessageType.InterceptedResponse ||
4141
request.Context is null ||
42-
request.Context.Session is null)
42+
request.Context.Session is null ||
43+
!ProxyUtils.MatchesUrlToWatch(UrlsToWatch, request.Context.Session.HttpClient.Request.RequestUri.AbsoluteUri))
4344
{
4445
continue;
4546
}

0 commit comments

Comments
 (0)