Skip to content

Lint errors which block CI should be reported in editor #8517

@RikkiGibson

Description

@RikkiGibson

It's quite possible I am missing an extension or editor setting which lets lint warnings be reported live in the editor. I did install the prettier vscode extension, but no diagnostics actually lit up in the editor, and it wasn't clear what I could try to actually make things light up. It's also possible the way to do this is documented and I just missed it.

At this point I am having CI runs get hung up on stuff like the following and it is slowing me down.

https://dev.azure.com/dnceng-public/public/_build/results?buildId=1118910&view=logs&j=d59c271a-63d2-5d1b-33e1-21d7b0c1fe89&t=f1e54274-737a-5c19-6e4e-f16bbd1d4112

> csharp@2.89.6-g47dad13398 compile
> tsc -p ./ && npx eslint ./ && npm run l10nDevGenerateLocalizationBundle && npm run compile:razorTextMate


/home/vsts/work/1/s/test/lsptoolshost/integrationTests/restore.integration.test.ts
  52:16  error  Functions that return promises must be async  @typescript-eslint/promise-function-async

/home/vsts/work/1/s/test/lsptoolshost/integrationTests/testHooks.ts
  15:18  error  An empty interface declaration allows any non-nullish value, including literals like `0` and `""`.
- If that's what you want, disable this lint rule with an inline comment or configure the 'allowInterfaces' rule option.
- If you want a type meaning "any object", you probably want `object` instead.
- If you want a type meaning "any value", you probably want `unknown` instead  @typescript-eslint/no-empty-object-type
  15:50  error  Delete `⏎`                                                                                                                                                                                                                                                                                                                                                                                prettier/prettier

✖ 3 problems (3 errors, 0 warnings)
  2 errors and 0 warnings potentially fixable with the `--fix` option.

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions