Fix bad handling of SCIP limits. Close #98

Author: AntoinePrv

libecole/src/dynamics/branching.cpp

@@ -36,7 +36,11 @@ std::optional<xt::xtensor<std::size_t, 1>> action_set(scip::Model const& model,
 
 auto BranchingDynamics::reset_dynamics(scip::Model& model) -> std::tuple<bool, ActionSet> {
 	model.solve_iter();
-	return {model.solve_iter_is_done(), action_set(model, pseudo_candidates)};
+	auto const done = model.solve_iter_is_done();
+	if (done) {
+		return {done, {}};
+	}
+	return {done, action_set(model, pseudo_candidates)};
 }
 
 auto BranchingDynamics::step_dynamics(scip::Model& model, std::size_t const& action) -> std::tuple<bool, ActionSet> {

libecole/src/scip/scimpl.cpp

@@ -86,7 +86,7 @@ void Scimpl::solve_iter() {
 			scip::call(
 				SCIPincludeObjBranchrule,
 				scip_ptr,
-				new ReverseBranchrule(scip_ptr, weak_executor),  // NOLINT
+				new ReverseBranchrule(scip_ptr, std::move(weak_executor)),  // NOLINT
 				true);
 			scip::call(SCIPsolve, scip_ptr);  // NOLINT
 		});