date conversion

Author: jraymakers

bindings/src/duckdb_node_bindings.cpp

@@ -1014,21 +1014,41 @@ class DuckDBNodeAddon : public Napi::Addon<DuckDBNodeAddon> {
   // function from_date(date: Date_): DateParts
   Napi::Value from_date(const Napi::CallbackInfo& info) {
     auto env = info.Env();
-    throw Napi::Error::New(env, "Not implemented yet");
+    auto date_obj = info[0].As<Napi::Object>();
+    auto days = date_obj.Get("days").As<Napi::Number>().Int32Value();
+    duckdb_date date = { days };
+    auto date_parts = duckdb_from_date(date);
+    auto result = Napi::Object::New(env);
+    result.Set("year", Napi::Number::New(env, date_parts.year));
+    result.Set("month", Napi::Number::New(env, date_parts.month));
+    result.Set("day", Napi::Number::New(env, date_parts.day));
+    return result;
   }
 
   // DUCKDB_API duckdb_date duckdb_to_date(duckdb_date_struct date);
   // function to_date(parts: DateParts): Date_
   Napi::Value to_date(const Napi::CallbackInfo& info) {
     auto env = info.Env();
-    throw Napi::Error::New(env, "Not implemented yet");
+    auto date_parts_obj = info[0].As<Napi::Object>();
+    int32_t year = date_parts_obj.Get("year").As<Napi::Number>().Int32Value();
+    int8_t month = date_parts_obj.Get("month").As<Napi::Number>().Int32Value();
+    int8_t day = date_parts_obj.Get("day").As<Napi::Number>().Int32Value();
+    duckdb_date_struct date_parts { year, month, day };
+    auto date = duckdb_to_date(date_parts);
+    auto result = Napi::Object::New(env);
+    result.Set("days", Napi::Number::New(env, date.days));
+    return result;
   }
 
   // DUCKDB_API bool duckdb_is_finite_date(duckdb_date date);
   // function is_finite_date(date: Date_): boolean
   Napi::Value is_finite_date(const Napi::CallbackInfo& info) {
     auto env = info.Env();
-    throw Napi::Error::New(env, "Not implemented yet");
+    auto date_obj = info[0].As<Napi::Object>();
+    auto days = date_obj.Get("days").As<Napi::Number>().Int32Value();
+    duckdb_date date = { days };
+    auto is_finite = duckdb_is_finite_date(date);
+    return Napi::Boolean::New(env, is_finite);
   }
 
   // DUCKDB_API duckdb_time_struct duckdb_from_time(duckdb_time time);

bindings/test/conversion.test.ts

@@ -0,0 +1,39 @@
+
+import duckdb from '@duckdb/node-bindings';
+import { expect, suite, test } from 'vitest';
+
+suite('conversion', () => {
+  suite('from_date', () => {
+    test('mid-range', () => {
+      expect(duckdb.from_date({ days: 19877 })).toStrictEqual({ year: 2024, month: 6, day: 3 });
+    });
+    test('max', () => {
+      expect(duckdb.from_date({ days: 0x7FFFFFFE })).toStrictEqual({ year: 5881580, month: 7, day: 10 });
+    });
+    test('min', () => {
+      expect(duckdb.from_date({ days: -0x7FFFFFFE })).toStrictEqual({ year: -5877641, month: 6, day: 25 });
+    });
+  });
+  suite('to_date', () => {
+    test('mid-range', () => {
+      expect(duckdb.to_date({ year: 2024, month: 6, day: 3 })).toStrictEqual({ days: 19877 });
+    });
+    test('max', () => {
+      expect(duckdb.to_date({ year: 5881580, month: 7, day: 10 })).toStrictEqual({ days: 0x7FFFFFFE });
+    });
+    test('min', () => {
+      expect(duckdb.to_date({ year: -5877641, month: 6, day: 25 })).toStrictEqual({ days: -0x7FFFFFFE });
+    });
+  });
+  suite('is_finite_date', () => {
+    test('finite', () => {
+      expect(duckdb.is_finite_date({ days: 19877 })).toBe(true);
+    });
+    test('infinity', () => {
+      expect(duckdb.is_finite_date({ days: 0x7FFFFFFF })).toBe(false);
+    });
+    test('-infinity', () => {
+      expect(duckdb.is_finite_date({ days: -0x7FFFFFFF })).toBe(false);
+    });
+  });
+});