finalizers

Author: jraymakers

api/src/DuckDBAppender.ts

@@ -14,9 +14,6 @@ export class DuckDBAppender {
   constructor(appender: duckdb.Appender) {
     this.appender = appender;
   }
-  public dispose() {
-    duckdb.appender_destroy(this.appender);
-  }
   public close() {
     duckdb.appender_close(this.appender);
   }

api/src/DuckDBConnection.ts

@@ -15,9 +15,6 @@ export class DuckDBConnection {
   ): Promise<DuckDBConnection> {
     return instance.connect();
   }
-  public dispose(): Promise<void> {
-    return duckdb.disconnect(this.connection);
-  }
   public interrupt() {
     duckdb.interrupt(this.connection);
   }
@@ -38,15 +35,11 @@ export class DuckDBConnection {
     const { extracted_statements, statement_count } =
       await duckdb.extract_statements(this.connection, sql);
     if (statement_count === 0) {
-      try {
-        throw new Error(
-          `Failed to extract statements: ${duckdb.extract_statements_error(
-            extracted_statements
-          )}`
-        );
-      } finally {
-        duckdb.destroy_extracted(extracted_statements);
-      }
+      throw new Error(
+        `Failed to extract statements: ${duckdb.extract_statements_error(
+          extracted_statements
+        )}`
+      );
     }
     return new DuckDBExtractedStatements(
       this.connection,

api/src/DuckDBDataChunk.ts

@@ -9,9 +9,6 @@ export class DuckDBDataChunk {
   public static create(logical_types: duckdb.LogicalType[]): DuckDBDataChunk {
     return new DuckDBDataChunk(duckdb.create_data_chunk(logical_types));
   }
-  public dispose() {
-    duckdb.destroy_data_chunk(this.chunk);
-  }
   public reset() {
     duckdb.data_chunk_reset(this.chunk);
   }

api/src/DuckDBExtractedStatements.ts

@@ -14,9 +14,6 @@ export class DuckDBExtractedStatements {
     this.extracted_statements = extracted_statements;
     this.statement_count = statement_count;
   }
-  public dispose() {
-    duckdb.destroy_extracted(this.extracted_statements);
-  }
   public get count(): number {
     return this.statement_count;
   }

api/src/DuckDBInstance.ts

@@ -12,22 +12,15 @@ export class DuckDBInstance {
   ): Promise<DuckDBInstance> {
     if (options) {
       const config = duckdb.create_config();
-      try {
-        for (const optionName in options) {
-          const optionValue = String(options[optionName]);
-          duckdb.set_config(config, optionName, optionValue);
-        }
-        return new DuckDBInstance(await duckdb.open(path, config));
-      } finally {
-        duckdb.destroy_config(config);
+      for (const optionName in options) {
+        const optionValue = String(options[optionName]);
+        duckdb.set_config(config, optionName, optionValue);
       }
+      return new DuckDBInstance(await duckdb.open(path, config));
     } else {
       return new DuckDBInstance(await duckdb.open(path));
     }
   }
-  public dispose(): Promise<void> {
-    return duckdb.close(this.db);
-  }
   public async connect(): Promise<DuckDBConnection> {
     return new DuckDBConnection(await duckdb.connect(this.db));
   }

api/src/DuckDBLogicalType.ts

@@ -48,7 +48,6 @@ export class DuckDBLogicalType {
   static consumeAsType(logical_type: duckdb.LogicalType): DuckDBType {
     const logicalType = DuckDBLogicalType.create(logical_type);
     const type = logicalType.asType();
-    logicalType.dispose();
     return type;
   }
   static create(logical_type: duckdb.LogicalType): DuckDBLogicalType {
@@ -145,9 +144,6 @@ export class DuckDBLogicalType {
       duckdb.create_union_type(member_types, member_names)
     );
   }
-  public dispose() {
-    duckdb.destroy_logical_type(this.logical_type);
-  }
   public get typeId(): DuckDBTypeId {
     return duckdb.get_type_id(this.logical_type) as number as DuckDBTypeId;
   }

api/src/DuckDBPendingResult.ts

@@ -13,9 +13,6 @@ export class DuckDBPendingResult {
   constructor(pending_result: duckdb.PendingResult) {
     this.pending_result = pending_result;
   }
-  public dispose() {
-    duckdb.destroy_pending(this.pending_result);
-  }
   public runTask(): DuckDBPendingResultState {
     const pending_state = duckdb.pending_execute_task(this.pending_result);
     switch (pending_state) {

api/src/DuckDBPreparedStatement.ts

@@ -16,9 +16,6 @@ export class DuckDBPreparedStatement {
   constructor(prepared_statement: duckdb.PreparedStatement) {
     this.prepared_statement = prepared_statement;
   }
-  public dispose() {
-    duckdb.destroy_prepare(this.prepared_statement);
-  }
   public get statementType(): StatementType {
     return duckdb.prepared_statement_type(this.prepared_statement);
   }

api/src/DuckDBResult.ts

@@ -10,9 +10,6 @@ export class DuckDBResult {
   constructor(result: duckdb.Result) {
     this.result = result;
   }
-  public dispose() {
-    duckdb.destroy_result(this.result);
-  }
   public get returnType(): ResultReturnType {
     return duckdb.result_return_type(this.result);
   }