uhugeint conversion

Author: jraymakers

bindings/src/duckdb_node_bindings.cpp

@@ -1263,14 +1263,33 @@ class DuckDBNodeAddon : public Napi::Addon<DuckDBNodeAddon> {
   // function uhugeint_to_double(uhugeint: bigint): number
   Napi::Value uhugeint_to_double(const Napi::CallbackInfo& info) {
     auto env = info.Env();
-    throw Napi::Error::New(env, "Not implemented yet");
+    auto uhugeint_as_bigint = info[0].As<Napi::BigInt>();
+    int sign_bit;
+    size_t word_count = 2;
+    uint64_t words[2];
+    uhugeint_as_bigint.ToWords(&sign_bit, &word_count, words);
+    if (word_count > 2 || sign_bit) {
+      throw Napi::Error::New(env, "bigint out of uhugeint range");
+    }
+    uint64_t lower = word_count > 0 ? words[0] : 0;
+    uint64_t upper = word_count > 1 ? words[1] : 0;
+    duckdb_uhugeint uhugeint = { lower, upper };
+    auto output_double = duckdb_uhugeint_to_double(uhugeint);
+    return Napi::Number::New(env, output_double);
   }
 
   // DUCKDB_API duckdb_uhugeint duckdb_double_to_uhugeint(double val);
   // function double_to_uhugeint(double: number): bigint
   Napi::Value double_to_uhugeint(const Napi::CallbackInfo& info) {
     auto env = info.Env();
-    throw Napi::Error::New(env, "Not implemented yet");
+    auto input_double = info[0].As<Napi::Number>().DoubleValue();
+    auto uhugeint = duckdb_double_to_uhugeint(input_double);
+    int sign_bit = 0;
+    size_t word_count = 2;
+    uint64_t words[2];
+    words[0] = uhugeint.lower;
+    words[1] = uhugeint.upper;
+    return Napi::BigInt::New(env, sign_bit, word_count, words);
   }
 
   // DUCKDB_API duckdb_decimal duckdb_double_to_decimal(double val, uint8_t width, uint8_t scale);

bindings/test/conversion.test.ts

@@ -179,12 +179,12 @@ suite('conversion', () => {
     });
   });
   suite('hugeint_to_double', () => {
-    test('one', () => {
-      expect(duckdb.hugeint_to_double(1n)).toBe(1);
-    });
     test('zero', () => {
       expect(duckdb.hugeint_to_double(0n)).toBe(0);
     });
+    test('one', () => {
+      expect(duckdb.hugeint_to_double(1n)).toBe(1);
+    });
     test('negative one', () => {
       expect(duckdb.hugeint_to_double(-1n)).toBe(-1);
     });
@@ -212,17 +212,20 @@ suite('conversion', () => {
     test('near max', () => {
       expect(duckdb.hugeint_to_double(2n ** 127n - 2n ** 74n)).toBe(1.7014118346046922e+38);
     });
-    test('out of range', () => {
+    test('out of range (positive)', () => {
       expect(() => duckdb.hugeint_to_double(2n ** 129n)).toThrowError('bigint out of hugeint range');
     });
+    test('out of range (negative)', () => {
+      expect(() => duckdb.hugeint_to_double(-(2n ** 129n))).toThrowError('bigint out of hugeint range');
+    });
   });
   suite('double_to_hugeint', () => {
-    test('one', () => {
-      expect(duckdb.double_to_hugeint(1)).toBe(1n);
-    });
     test('zero', () => {
       expect(duckdb.double_to_hugeint(0)).toBe(0n);
     });
+    test('one', () => {
+      expect(duckdb.double_to_hugeint(1)).toBe(1n);
+    });
     test('negative one', () => {
       expect(duckdb.double_to_hugeint(-1)).toBe(-1n);
     });
@@ -245,4 +248,47 @@ suite('conversion', () => {
       expect(duckdb.double_to_hugeint(1.7014118346046922e+38)).toBe(2n ** 127n - 2n ** 74n);
     });
   });
+  suite('uhugeint_to_double', () => {
+    test('zero', () => {
+      expect(duckdb.uhugeint_to_double(0n)).toBe(0);
+    });
+    test('one', () => {
+      expect(duckdb.uhugeint_to_double(1n)).toBe(1);
+    });
+    test('one word', () => {
+      expect(duckdb.uhugeint_to_double(2n ** 63n)).toBe(9.223372036854776e+18);
+    });
+    test('two words', () => {
+      expect(duckdb.uhugeint_to_double(2n ** 65n)).toBe(3.6893488147419103e+19);
+    });
+    test('max', () => {
+      expect(duckdb.uhugeint_to_double(2n ** 127n - 1n)).toBe(1.7014118346046923e+38);
+    });
+    test('near max', () => {
+      expect(duckdb.uhugeint_to_double(2n ** 127n - 2n ** 74n)).toBe(1.7014118346046922e+38);
+    });
+    test('out of range (positive)', () => {
+      expect(() => duckdb.uhugeint_to_double(2n ** 129n)).toThrowError('bigint out of uhugeint range');
+    });
+    test('out of range (negative)', () => {
+      expect(() => duckdb.uhugeint_to_double(-1n)).toThrowError('bigint out of uhugeint range');
+    });
+  });
+  suite('double_to_uhugeint', () => {
+    test('zero', () => {
+      expect(duckdb.double_to_uhugeint(0)).toBe(0n);
+    });
+    test('one', () => {
+      expect(duckdb.double_to_uhugeint(1)).toBe(1n);
+    });
+    test('one word', () => {
+      expect(duckdb.double_to_uhugeint(9.223372036854776e+18)).toBe(2n ** 63n);
+    });
+    test('two words', () => {
+      expect(duckdb.double_to_uhugeint(3.6893488147419103e+19)).toBe(2n ** 65n);
+    });
+    test('near max', () => {
+      expect(duckdb.double_to_uhugeint(1.7014118346046922e+38)).toBe(2n ** 127n - 2n ** 74n);
+    });
+  });
 });