Skip to content

Commit 8975a8a

Browse files
committed
pass TARGET_ARCH to node-gyp
1 parent bfcfdc1 commit 8975a8a

File tree

2 files changed

+1
-6
lines changed

2 files changed

+1
-6
lines changed

.github/workflows/DuckDBNodeBindingsAndAPI.yml

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -123,9 +123,6 @@ jobs:
123123
env:
124124
TARGET_ARCH: ${{ 'arm64' }}
125125
steps:
126-
- name: Echo TARGET_ARGH
127-
run: echo $TARGET_ARCH
128-
129126
- uses: actions/checkout@v4
130127

131128
- uses: pnpm/action-setup@v3
@@ -138,8 +135,6 @@ jobs:
138135
- name: Bindings - Build
139136
working-directory: bindings
140137
run: pnpm run build
141-
env:
142-
TARGET_ARCH: ${{ 'arm64' }}
143138

144139
- name: Bindings - Test
145140
working-directory: bindings

bindings/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
"private": true,
33
"scripts": {
44
"build": "npm run build:package && npm run build:test",
5-
"build:package": "node-gyp configure && node-gyp build",
5+
"build:package": "node-gyp configure --arch=$TARGET_ARCH && node-gyp build --arch=$TARGET_ARCH",
66
"build:test": "tsc -b test",
77
"clean": "npm run clean:gyp && npm run clean:libduckdb && npm run clean:package",
88
"clean:gyp": "node-gyp clean",

0 commit comments

Comments
 (0)