Merge pull request #224 from duckdb/jray/fix-run-with-params

fix run with params

Author: jraymakers

api/src/DuckDBConnection.ts

@@ -28,11 +28,11 @@ export class DuckDBConnection {
   }
   /** Same as disconnectSync. */
   public closeSync() {
-    return this.disconnectSync();
+    this.disconnectSync();
   }
   public disconnectSync() {
     this.preparedStatements.destroySync();
-    return duckdb.disconnect_sync(this.connection);
+    duckdb.disconnect_sync(this.connection);
   }
   public interrupt() {
     duckdb.interrupt(this.connection);
@@ -49,7 +49,8 @@ export class DuckDBConnection {
       const prepared = await this.createPrepared(sql);
       try {
         prepared.bind(values, types);
-        return prepared.run();
+        const result = await prepared.run();
+        return result;
       } finally {
         prepared.destroySync();
       }
@@ -95,7 +96,8 @@ export class DuckDBConnection {
       if (values) {
         prepared.bind(values, types);
       }
-      return prepared.stream();
+      const result = await prepared.stream();
+      return result;
     } finally {
       prepared.destroySync();
     }

api/test/api.test.ts

@@ -785,6 +785,13 @@ describe('api', () => {
       );
     });
   });
+  test('runAndReadAll with params', async () => {
+    await withConnection(async (connection) => {
+      const reader = await connection.runAndReadAll('select ? as n', [17]);
+      const rows = reader.getRowObjects();
+      assert.deepEqual(rows, [{ n: 17 }]);
+    });
+  });
   test('should support all data types', async () => {
     await withConnection(async (connection) => {
       const result = await connection.run(