Skip to content

Commit 04b8764

Browse files
brianhallgithub-actions[bot]
authored andcommitted
Release build 10.9.1 [ci release]
1 parent c46231f commit 04b8764

File tree

9 files changed

+13
-10
lines changed

9 files changed

+13
-10
lines changed

CHANGELOG.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
- Add conditional action type (#1799)
1+
- Change condition return signature (#1809)

Sources/ContentScopeScripts/dist/contentScopeIsolated.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11661,7 +11661,7 @@ ul.messages {
1166111661
response: { actions: action.actions }
1166211662
});
1166311663
}
11664-
return new SuccessResponse({ actionID: action.id, actionType: action.actionType, response: null });
11664+
return new SuccessResponse({ actionID: action.id, actionType: action.actionType, response: { actions: [] } });
1166511665
}
1166611666

1166711667
// src/features/broker-protection/execute.js

build/android/brokerProtection.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8382,7 +8382,7 @@
83828382
response: { actions: action.actions }
83838383
});
83848384
}
8385-
return new SuccessResponse({ actionID: action.id, actionType: action.actionType, response: null });
8385+
return new SuccessResponse({ actionID: action.id, actionType: action.actionType, response: { actions: [] } });
83868386
}
83878387

83888388
// src/features/broker-protection/execute.js

build/integration/contentScope.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18910,7 +18910,7 @@ ul.messages {
1891018910
response: { actions: action.actions }
1891118911
});
1891218912
}
18913-
return new SuccessResponse({ actionID: action.id, actionType: action.actionType, response: null });
18913+
return new SuccessResponse({ actionID: action.id, actionType: action.actionType, response: { actions: [] } });
1891418914
}
1891518915

1891618916
// src/features/broker-protection/execute.js

build/windows/contentScope.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13887,7 +13887,7 @@
1388713887
response: { actions: action.actions }
1388813888
});
1388913889
}
13890-
return new SuccessResponse({ actionID: action.id, actionType: action.actionType, response: null });
13890+
return new SuccessResponse({ actionID: action.id, actionType: action.actionType, response: { actions: [] } });
1389113891
}
1389213892

1389313893
// src/features/broker-protection/execute.js

injected/integration-test/broker-protection-tests/broker-protection.spec.js

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -682,7 +682,7 @@ test.describe('Broker Protection communications', () => {
682682
expect(successResponse.actions.length).toBeGreaterThan(0);
683683
});
684684

685-
test('a condition with failSilently returns success with empty response', async ({ page }, workerInfo) => {
685+
test('a condition with failSilently returns success with empty actions array', async ({ page }, workerInfo) => {
686686
const dbp = BrokerProtectionPage.create(page, workerInfo.project.use);
687687
await dbp.enabled();
688688
await dbp.navigatesTo('form.html');
@@ -692,7 +692,10 @@ test.describe('Broker Protection communications', () => {
692692

693693
// Check that the response does not contain an actions array
694694
const successResponse = await dbp.getSuccessResponse();
695-
expect(successResponse).toBeNull();
695+
696+
expect(successResponse).toHaveProperty('actions');
697+
expect(Array.isArray(successResponse.actions)).toBe(true);
698+
expect(successResponse.actions.length).toBe(0);
696699
});
697700

698701
test('a failing condition returns error', async ({ page }, workerInfo) => {

injected/integration-test/extension/contentScope.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18910,7 +18910,7 @@ ul.messages {
1891018910
response: { actions: action.actions }
1891118911
});
1891218912
}
18913-
return new SuccessResponse({ actionID: action.id, actionType: action.actionType, response: null });
18913+
return new SuccessResponse({ actionID: action.id, actionType: action.actionType, response: { actions: [] } });
1891418914
}
1891518915

1891618916
// src/features/broker-protection/execute.js

injected/integration-test/test-pages/build/contentScope.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18910,7 +18910,7 @@ ul.messages {
1891018910
response: { actions: action.actions }
1891118911
});
1891218912
}
18913-
return new SuccessResponse({ actionID: action.id, actionType: action.actionType, response: null });
18913+
return new SuccessResponse({ actionID: action.id, actionType: action.actionType, response: { actions: [] } });
1891418914
}
1891518915

1891618916
// src/features/broker-protection/execute.js

injected/src/features/broker-protection/actions/condition.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,5 +35,5 @@ export function condition(action, root = document) {
3535
});
3636
}
3737

38-
return new SuccessResponse({ actionID: action.id, actionType: action.actionType, response: null });
38+
return new SuccessResponse({ actionID: action.id, actionType: action.actionType, response: { actions: [] } });
3939
}

0 commit comments

Comments
 (0)