Release build 8.11.0 [ci release]

Author: mgurgel

CHANGELOG.txt

@@ -1,4 +1 @@
-- feat(pir): deprecate useEnhancedCaptchaSystem setting (#1608)
-- Fixes privacy-config hash on CI (#1605)
-- Update asana.yml (#1562)
-- Ensure getFeatureSettingEnabled behaves as expected (#1607)
+- ntp: send background-tab on windows middle-click (#1595)

Sources/ContentScopeScripts/dist/pages/history/dist/index.js

@@ -4457,9 +4457,9 @@
   // shared/handlers.js
   function eventToTarget(event, platformName) {
     const isControlClick = platformName === "macos" ? event.metaKey : event.ctrlKey;
-    if (isControlClick) {
+    if (isControlClick || "button" in event && event.button === 1) {
       return "new-tab";
-    } else if (event.shiftKey || "button" in event && event.button === 1) {
+    } else if (event.shiftKey) {
       return "new-window";
     }
     return "same-tab";

Sources/ContentScopeScripts/dist/pages/new-tab/dist/index.js

@@ -3167,8 +3167,10 @@
     const isControlClick = platformName === "macos" ? event.metaKey : event.ctrlKey;
     if (isControlClick) {
       return "new-tab";
-    } else if (event.shiftKey || event.button === 1) {
+    } else if (event.shiftKey) {
       return "new-window";
+    } else if (event.button === 1) {
+      return "new-tab";
     }
     return "same-tab";
   }

build/integration/pages/history/dist/index.js

@@ -4457,9 +4457,9 @@
   // shared/handlers.js
   function eventToTarget(event, platformName) {
     const isControlClick = platformName === "macos" ? event.metaKey : event.ctrlKey;
-    if (isControlClick) {
+    if (isControlClick || "button" in event && event.button === 1) {
       return "new-tab";
-    } else if (event.shiftKey || "button" in event && event.button === 1) {
+    } else if (event.shiftKey) {
       return "new-window";
     }
     return "same-tab";

build/integration/pages/new-tab/dist/index.js

@@ -3167,8 +3167,10 @@
     const isControlClick = platformName === "macos" ? event.metaKey : event.ctrlKey;
     if (isControlClick) {
       return "new-tab";
-    } else if (event.shiftKey || event.button === 1) {
+    } else if (event.shiftKey) {
       return "new-window";
+    } else if (event.button === 1) {
+      return "new-tab";
     }
     return "same-tab";
   }

build/windows/pages/history/dist/index.js

@@ -4457,9 +4457,9 @@
   // shared/handlers.js
   function eventToTarget(event, platformName) {
     const isControlClick = platformName === "macos" ? event.metaKey : event.ctrlKey;
-    if (isControlClick) {
+    if (isControlClick || "button" in event && event.button === 1) {
       return "new-tab";
-    } else if (event.shiftKey || "button" in event && event.button === 1) {
+    } else if (event.shiftKey) {
       return "new-window";
     }
     return "same-tab";

build/windows/pages/new-tab/dist/index.js

@@ -3167,8 +3167,10 @@
     const isControlClick = platformName === "macos" ? event.metaKey : event.ctrlKey;
     if (isControlClick) {
       return "new-tab";
-    } else if (event.shiftKey || event.button === 1) {
+    } else if (event.shiftKey) {
       return "new-window";
+    } else if (event.button === 1) {
+      return "new-tab";
     }
     return "same-tab";
   }

special-pages/pages/history/integration-tests/history.page.js

@@ -204,7 +204,7 @@ export class HistoryTestPage {
 
         expect(calls[3].payload.params).toStrictEqual({
             url,
-            target: 'new-window',
+            target: 'new-tab',
         });
     }
 

special-pages/pages/new-tab/app/activity/integration-tests/activity.page.js

@@ -213,7 +213,7 @@ export class ActivityPage {
 
         expect(calls[3].payload.params).toStrictEqual({
             url,
-            target: 'new-window',
+            target: 'new-tab',
         });
     }
 

special-pages/pages/new-tab/app/favorites/integration-tests/favorites.page.js

@@ -20,16 +20,16 @@ export class FavoritesPage {
 
     async opensInNewTab() {
         await this.nthFavorite(0).click({ modifiers: ['Meta'] });
+        await this.nthFavorite(0).click({ button: 'middle' });
         const calls = await this.ntp.mocks.waitForCallCount({ method: 'favorites_open', count: 1 });
         expect(calls[0].payload.params).toStrictEqual({ id: 'id-many-1', url: 'https://example.com/?id=id-many-1', target: 'new-tab' });
+        expect(calls[1].payload.params).toStrictEqual({ id: 'id-many-1', url: 'https://example.com/?id=id-many-1', target: 'new-tab' });
     }
 
     async opensInNewWindow() {
         await this.nthFavorite(0).click({ modifiers: ['Shift'] });
-        await this.nthFavorite(0).click({ button: 'middle' });
-        const calls = await this.ntp.mocks.waitForCallCount({ method: 'favorites_open', count: 2 });
+        const calls = await this.ntp.mocks.waitForCallCount({ method: 'favorites_open', count: 1 });
         expect(calls[0].payload.params).toStrictEqual({ id: 'id-many-1', url: 'https://example.com/?id=id-many-1', target: 'new-window' });
-        expect(calls[1].payload.params).toStrictEqual({ id: 'id-many-1', url: 'https://example.com/?id=id-many-1', target: 'new-window' });
     }
 
     async opensInSameTab() {