Skip to content

Commit 36f57a1

Browse files
Ensure cookie feature scripts load properly on windows platform (#250)
The cookie feature was breaking on windows due to: loadedPolicyResolve not being set, content scope scripts ignore the minSupportedVersion in remtoe config The minSupportedVersion has been fixed on wndows now by providing a modified remote config to the scripts where the feature's state is changed to 'disabled' if the minSupportedVersion is higher than current version. This fixes the other issue, where parts of the cookie feature logic were not executed (and scripts were breaking due to loadedPolicyResolve missing), meaning we can now run the JS cookie feature in Windows as well.
1 parent 817ff2d commit 36f57a1

File tree

8 files changed

+15
-15
lines changed

8 files changed

+15
-15
lines changed

Sources/ContentScopeScripts/dist/contentScope.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4515,8 +4515,8 @@
45154515
}
45164516

45174517
function load (args) {
4518-
// Feature is only relevant to the extension, we should skip for other platforms for now as the config testing is broken.
4519-
if (args.platform.name !== 'extension') {
4518+
// Feature is only relevant to the extension and windows, we should skip for other platforms for now as the config testing is broken.
4519+
if (args.platform.name !== 'extension' && args.platform.name !== 'windows') {
45204520
return
45214521
}
45224522
if (args.documentOriginIsTracker) {

build/android/contentScope.js

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

build/chrome-mv3/inject.js

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

build/chrome/inject.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

build/firefox/inject.js

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

build/integration/contentScope.js

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

build/windows/contentScope.js

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/features/cookie.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -53,8 +53,8 @@ function isNonTrackingCookie () {
5353
}
5454

5555
export function load (args) {
56-
// Feature is only relevant to the extension, we should skip for other platforms for now as the config testing is broken.
57-
if (args.platform.name !== 'extension') {
56+
// Feature is only relevant to the extension and windows, we should skip for other platforms for now as the config testing is broken.
57+
if (args.platform.name !== 'extension' && args.platform.name !== 'windows') {
5858
return
5959
}
6060
if (args.documentOriginIsTracker) {

0 commit comments

Comments
 (0)