Skip to content

Commit 3540988

Browse files
fix(gateway): correct root hash / chain creation params (#3613)
## What ❔ <!-- What are the changes this PR brings about? --> <!-- Example: This PR adds a PR template to the repo. --> <!-- (For bigger PRs adding more context is appreciated) --> ## Why ❔ <!-- Why are these changes done? What goal do they contribute to? What are the principles behind them? --> <!-- The `Why` has to be clear to non-Matter Labs entities running their own ZK Chain --> <!-- Example: PR templates ensure PR reviewers, observers, and future iterators are in context about the evolution of repos. --> ## Is this a breaking change? It is a partially breaking change, but we assume that no new chains were created with previous (i.e. wrong) params. - [ ] Yes - [x] No ## Operational changes <!-- Any config changes? Any new flags? Any changes to any scripts? --> <!-- Please add anything that non-Matter Labs entities running their own ZK Chain may need to know --> ## Checklist <!-- Check your PR fulfills the following items. --> <!-- For draft PRs check the boxes as you complete them. --> - [ ] PR title corresponds to the body of PR (we generate changelog entries from PRs). - [ ] Tests for the changes have been added / updated. - [ ] Documentation comments have been added / updated. - [ ] Code has been formatted via `zkstack dev fmt` and `zkstack dev lint`.
1 parent 0a1c9e5 commit 3540988

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

crates/common/src/contracts.rs

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,9 @@ use crate::cmd::Cmd;
66

77
pub fn build_l1_contracts(shell: Shell, link_to_code: PathBuf) -> anyhow::Result<()> {
88
let _dir_guard = shell.push_dir(link_to_code.join("contracts/l1-contracts"));
9+
// Do not update era-contract's lockfile to avoid dirty submodule
10+
// Note, tha the v26 contracts depend on the node_modules to be present at the time of the compilation.
11+
Cmd::new(cmd!(shell, "yarn install --frozen-lockfile")).run()?;
912
Ok(Cmd::new(cmd!(shell, "yarn build:foundry")).run()?)
1013
}
1114

@@ -22,7 +25,5 @@ pub fn build_l2_contracts(shell: Shell, link_to_code: PathBuf) -> anyhow::Result
2225

2326
pub fn build_system_contracts(shell: Shell, link_to_code: PathBuf) -> anyhow::Result<()> {
2427
let _dir_guard = shell.push_dir(link_to_code.join("contracts/system-contracts"));
25-
// Do not update era-contract's lockfile to avoid dirty submodule
26-
Cmd::new(cmd!(shell, "yarn install --frozen-lockfile")).run()?;
2728
Ok(Cmd::new(cmd!(shell, "yarn build:foundry")).run()?)
2829
}

0 commit comments

Comments
 (0)