go1.24, golangci-lint v2.2.0 + updated config

edoardottt · edoardottt · commit 1defae669f4c · 2025-08-20T09:36:22.000+02:00
diff --git a/.github/workflows/go.yml b/.github/workflows/go.yml
@@ -11,12 +11,12 @@ jobs:
   build:
     runs-on: ubuntu-latest
     steps:
-    - uses: actions/checkout@v2
+    - uses: actions/checkout@v4
 
     - name: Set up Go
-      uses: actions/setup-go@v2
+      uses: actions/setup-go@v5
       with:
-        go-version: 1.23
+        go-version: 1.24
 
     - name: Build
       run: go build -v ./...
diff --git a/.github/workflows/golangci-lint.yml b/.github/workflows/golangci-lint.yml
@@ -16,15 +16,15 @@ jobs:
     name: lint
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/setup-go@v3
+      - uses: actions/setup-go@v5
         with:
-          go-version: 1.23
-      - uses: actions/checkout@v3
+          go-version: 1.24
+      - uses: actions/checkout@v4
       - name: golangci-lint
-        uses: golangci/golangci-lint-action@v3
+        uses: golangci/golangci-lint-action@v8
         with:
           # Optional: version of golangci-lint to use in form of v1.2 or v1.2.3 or `latest` to use the latest version
-          version: v1.61.0
+          version: v2.2.0
 
           # Optional: working directory, useful for monorepos
           # working-directory: somedir
diff --git a/.github/workflows/release-binary.yml b/.github/workflows/release-binary.yml
@@ -11,18 +11,18 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: "Check out code"
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
         with: 
           fetch-depth: 0
 
       - name: "Set up Go"
-        uses: actions/setup-go@v4
+        uses: actions/setup-go@v5
         with: 
-          go-version: 1.23.x
+          go-version: 1.24
 
       - name: "Create release on GitHub"
         timeout-minutes: 10
-        uses: goreleaser/goreleaser-action@v4
+        uses: goreleaser/goreleaser-action@v6
         with: 
           args: "release --clean"
           version: latest
diff --git a/.github/workflows/release-test.yml b/.github/workflows/release-test.yml
@@ -12,17 +12,19 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: "Check out code"
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
         with: 
           fetch-depth: 0
 
       - name: Set up Go
-        uses: actions/setup-go@v4
+        uses: actions/setup-go@v5
         with:
-          go-version: 1.23.x
+          go-version: 1.24
       
       - name: release test
-        uses: goreleaser/goreleaser-action@v4
+        uses: goreleaser/goreleaser-action@v6
         with:
           args: "release --clean --snapshot"
-          version: latest
+          version: latest
+        env: 
+          GITHUB_TOKEN: "${{ secrets.GITHUB_TOKEN }}"
diff --git a/.golangci.yml b/.golangci.yml
@@ -1,7 +1,6 @@
+version: "2"
 linters:
-  # Enable all available linters.
-  # Default: false
-  disable-all: true
+  default: none
   enable:
     - asciicheck
     - bodyclose
@@ -20,10 +19,8 @@ linters:
     - goheader
     - gomodguard
     - goprintffuncname
-    - gosimple
     - govet
     - ineffassign
-    - lll
     - misspell
     - mnd
     - nakedret
@@ -32,24 +29,24 @@ linters:
     - rowserrcheck
     - sqlclosecheck
     - staticcheck
-    - stylecheck
     - testpackage
-    - typecheck
     - unconvert
     - unparam
     - unused
     - whitespace
-    - wsl
-
-linters-settings:
-  wsl:
-    strict-append: false
-    enforce-err-cuddling: true
-
-  mnd:
-    # Values always ignored: "1", "1.0", "0" and "0.0"
-    # Default: []
-    ignored-numbers:
-      - '2'
-    ignored-files:
-      - 'crawler/useragents.go'
+    - wsl_v5
+  exclusions:
+    generated: lax
+    presets:
+      - std-error-handling
+    paths:
+      - third_party$
+      - builtin$
+      - examples$
+formatters:
+  exclusions:
+    generated: lax
+    paths:
+      - third_party$
+      - builtin$
+      - examples$
diff --git a/go.mod b/go.mod
@@ -1,6 +1,6 @@
 module github.com/edoardottt/cariddi
 
-go 1.23.0
+go 1.24.0
 
 require (
 	github.com/fatih/color v1.18.0
diff --git a/internal/file/file.go b/internal/file/file.go
@@ -192,8 +192,8 @@ func ReadHTTPRequestFromFile(inputFile string) (*http.Request, error) {
 	defer f.Close()
 
 	buf := bufio.NewReader(f)
-	req, err := http.ReadRequest(buf)
 
+	req, err := http.ReadRequest(buf)
 	if err != nil {
 		fmt.Println("Cannot read request from input file.")
 		return req, err
diff --git a/internal/slice/slice.go b/internal/slice/slice.go
@@ -33,6 +33,10 @@ import (
 	"time"
 )
 
+const (
+	coupleSize = 2
+)
+
 // RemoveDuplicateValues removes duplicates from a slice
 // of strings.
 func RemoveDuplicateValues(strSlice []string) []string {
@@ -86,7 +90,7 @@ func CheckCookies(input string) []*http.Cookie {
 
 	for _, pair := range pairs {
 		couple := strings.Split(pair, ":")
-		if len(couple) != 2 {
+		if len(couple) != coupleSize {
 			continue
 		}
 
diff --git a/pkg/crawler/colly.go b/pkg/crawler/colly.go
@@ -68,8 +68,8 @@ func New(scan *Scan) *Results {
 
 	if scan.Intensive {
 		var err error
-		targetTemp, err = urlUtils.GetRootHost(fmt.Sprintf("%s://%s", protocolTemp, targetTemp))
 
+		targetTemp, err = urlUtils.GetRootHost(fmt.Sprintf("%s://%s", protocolTemp, targetTemp))
 		if err != nil {
 			fmt.Println(err.Error())
 			os.Exit(1)
@@ -153,8 +153,8 @@ func New(scan *Scan) *Results {
 		filetype := &scanner.FileType{}
 
 		// Skip if no scanning is enabled
-		if !(scan.EndpointsFlag || scan.SecretsFlag || (1 <= scan.FileType && scan.FileType <= 7) ||
-			scan.ErrorsFlag || scan.InfoFlag || scan.JSON) {
+		if !scan.EndpointsFlag && !scan.SecretsFlag && (scan.FileType < 1 || scan.FileType > 7) &&
+			!scan.ErrorsFlag && !scan.InfoFlag && !scan.JSON {
 			return
 		}
 
@@ -201,7 +201,6 @@ func New(scan *Scan) *Results {
 			jsonOutput, err := output.GetJSONString(
 				r, secrets, parameters, filetype, errors, infos,
 			)
-
 			if err == nil {
 				fmt.Println(string(jsonOutput))
 			} else {
diff --git a/pkg/crawler/scan.go b/pkg/crawler/scan.go
@@ -73,7 +73,9 @@ func huntSecrets(target, body string, secretsFile *[]string) []scanner.SecretMat
 					}
 
 					mu.Lock()
+
 					secrets = append(secrets, secretMatch)
+
 					mu.Unlock()
 				}
 			}(secret)
@@ -108,7 +110,9 @@ func huntSecrets(target, body string, secretsFile *[]string) []scanner.SecretMat
 					}
 
 					mu.Lock()
+
 					secrets = append(secrets, secretMatch)
+
 					mu.Unlock()
 				}
 			}(re)
@@ -140,6 +144,7 @@ func EndpointsMatch(target string, endpointsFile *[]string) []scanner.EndpointMa
 				}
 			}
 		}
+
 		endpoints = append(endpoints, scanner.EndpointMatched{Parameters: matched, URL: target})
 	} else {
 		for _, parameter := range *endpointsFile {
@@ -149,6 +154,7 @@ func EndpointsMatch(target string, endpointsFile *[]string) []scanner.EndpointMa
 				}
 			}
 		}
+
 		endpoints = append(endpoints, scanner.EndpointMatched{Parameters: matched, URL: target})
 	}
 
@@ -203,7 +209,9 @@ func huntErrors(target, body string) []scanner.ErrorMatched {
 			}
 
 			mutex.Lock()
+
 			results = append(results, localResults...)
+
 			mutex.Unlock()
 		}(err)
 	}
@@ -231,7 +239,9 @@ func huntInfos(target, body string) []scanner.InfoMatched {
 
 			for _, match := range matches {
 				mu.Lock()
+
 				infosSlice = append(infosSlice, scanner.InfoMatched{Info: infoItem, URL: target, Match: match[0]})
+
 				mu.Unlock()
 			}
 		}(infoItem)
diff --git a/pkg/crawler/useragents.go b/pkg/crawler/useragents.go
@@ -35,6 +35,10 @@ import (
 	"time"
 )
 
+const (
+	hundred = 100
+)
+
 // genOsString generates a random OS string for a User Agent.
 func genOsString() string {
 	source := rand.NewSource(time.Now().UnixNano())
@@ -151,7 +155,7 @@ func GenerateRandomUserAgent() string {
 	source := rand.NewSource(time.Now().UnixNano())
 	rng := rand.New(source)
 
-	decision := rng.Intn(100)
+	decision := rng.Intn(hundred)
 
 	var ua string
 	if decision%2 == 0 {
diff --git a/pkg/input/check.go b/pkg/input/check.go
@@ -64,7 +64,7 @@ func CheckFlags(flags Input) {
 	}
 
 	if flags.Extensions != 0 {
-		if !(1 <= flags.Extensions && flags.Extensions <= 7) {
+		if flags.Extensions < 1 || flags.Extensions > 7 {
 			fmt.Println("The extension value must go from 1 (juicy) to 7 (not juicy).")
 			os.Exit(1)
 		}
diff --git a/pkg/input/input.go b/pkg/input/input.go
@@ -36,6 +36,10 @@ import (
 	pdutils "github.com/projectdiscovery/utils/file"
 )
 
+const (
+	coupleSize = 2
+)
+
 // ScanTargets return the array of elements
 // taken as input on stdin.
 func ScanTargets() []string {
@@ -50,7 +54,7 @@ func ScanTargets() []string {
 	sc := bufio.NewScanner(os.Stdin)
 	for sc.Scan() {
 		domain := strings.ToLower(sc.Text())
-		if len(domain) > 2 {
+		if len(domain) > coupleSize {
 			result = append(result, domain)
 		}
 	}
@@ -74,7 +78,7 @@ func GetHeaders(input string) map[string]string {
 		for _, header := range headers {
 			var parts []string
 			if strings.Contains(header, ":") {
-				parts = strings.SplitN(header, ":", 2)
+				parts = strings.SplitN(header, ":", coupleSize)
 			} else {
 				continue
 			}
diff --git a/pkg/output/html.go b/pkg/output/html.go
@@ -37,7 +37,6 @@ import (
 )
 
 const (
-	//nolint:all
 	HTMLBanner = `<!DOCTYPE html>
 <html lang="en">
 <head>
@@ -97,7 +96,6 @@ const (
 		</ul>
 	</div>
 	<div class="container">`
-	//nolint:all
 	HTMLBannerFooter = `</div> <!-- End of .container -->
 	<footer style="background-color: #e2e8f0; text-align: center; padding: 1.5rem; font-size: 0.9rem; color: #4b5563;">
 		<p>Generated by <a href="https://github.com/edoardottt/cariddi" style="color: #0ea5e9; text-decoration: none;">Cariddi</a> – Stay safe out there! 🐙</p>
diff --git a/pkg/output/output.go b/pkg/output/output.go
@@ -139,7 +139,6 @@ func HTMLOutput(flags input.Input, resultFilename string, finalResults []string,
 	finalEndpoints []scanner.EndpointMatched, finalExtensions []scanner.FileTypeMatched,
 	finalErrors []scanner.ErrorMatched, finalInfos []scanner.InfoMatched) {
 	exists, err := fileUtils.ElementExists(CariddiOutputFolder)
-
 	if err != nil {
 		fmt.Println("Error while creating the output directory.")
 		os.Exit(1)
diff --git a/pkg/output/responses.go b/pkg/output/responses.go
@@ -94,7 +94,7 @@ func FormatResponse(resp *colly.Response) ([]byte, error) {
 	builder.WriteString("\n\n")
 	builder.WriteString("HTTP/1.1")
 	builder.WriteString(" ")
-	builder.WriteString(fmt.Sprint(resp.StatusCode))
+	fmt.Fprint(builder, resp.StatusCode)
 	builder.WriteString("\n")
 
 	for k, v := range *resp.Headers {

Original file line number	Diff line number	Diff line change
`@@ -73,7 +73,9 @@ func huntSecrets(target, body string, secretsFile *[]string) []scanner.SecretMat`
`73`	`73`	`}`
`74`	`74`
`75`	`75`	`mu.Lock()`
	`76`	`+`
`76`	`77`	`secrets = append(secrets, secretMatch)`
	`78`	`+`
`77`	`79`	`mu.Unlock()`
`78`	`80`	`}`
`79`	`81`	`}(secret)`
`@@ -108,7 +110,9 @@ func huntSecrets(target, body string, secretsFile *[]string) []scanner.SecretMat`
`108`	`110`	`}`
`109`	`111`
`110`	`112`	`mu.Lock()`
	`113`	`+`
`111`	`114`	`secrets = append(secrets, secretMatch)`
	`115`	`+`
`112`	`116`	`mu.Unlock()`
`113`	`117`	`}`
`114`	`118`	`}(re)`
`@@ -140,6 +144,7 @@ func EndpointsMatch(target string, endpointsFile *[]string) []scanner.EndpointMa`
`140`	`144`	`}`
`141`	`145`	`}`
`142`	`146`	`}`
	`147`	`+`
`143`	`148`	`endpoints = append(endpoints, scanner.EndpointMatched{Parameters: matched, URL: target})`
`144`	`149`	`} else {`
`145`	`150`	`for _, parameter := range *endpointsFile {`
`@@ -149,6 +154,7 @@ func EndpointsMatch(target string, endpointsFile *[]string) []scanner.EndpointMa`
`149`	`154`	`}`
`150`	`155`	`}`
`151`	`156`	`}`
	`157`	`+`
`152`	`158`	`endpoints = append(endpoints, scanner.EndpointMatched{Parameters: matched, URL: target})`
`153`	`159`	`}`
`154`	`160`
`@@ -203,7 +209,9 @@ func huntErrors(target, body string) []scanner.ErrorMatched {`
`203`	`209`	`}`
`204`	`210`
`205`	`211`	`mutex.Lock()`
	`212`	`+`
`206`	`213`	`results = append(results, localResults...)`
	`214`	`+`
`207`	`215`	`mutex.Unlock()`
`208`	`216`	`}(err)`
`209`	`217`	`}`
`@@ -231,7 +239,9 @@ func huntInfos(target, body string) []scanner.InfoMatched {`
`231`	`239`
`232`	`240`	`for _, match := range matches {`
`233`	`241`	`mu.Lock()`
	`242`	`+`
`234`	`243`	`infosSlice = append(infosSlice, scanner.InfoMatched{Info: infoItem, URL: target, Match: match[0]})`
	`244`	`+`
`235`	`245`	`mu.Unlock()`
`236`	`246`	`}`
`237`	`247`	`}(infoItem)`