refactor: update array syntax to use modern bracket notation and improve comments

Author: egbakou

src/ReedSolomon.NET.TablesGenerator/GeneratorHelpers.cs

@@ -12,7 +12,8 @@ public static class Helpers
     /// </summary>
     private const int GeneratingPolynomial = 29;
 
-    private static readonly short[] _logTable = {
+    private static readonly short[] _logTable =
+    [
         -1, 0, 1, 25, 2, 50, 26, 198,
         3, 223, 51, 238, 27, 104, 199, 75,
         4, 100, 224, 14, 52, 141, 239, 129,
@@ -44,8 +45,8 @@ public static class Helpers
         203, 89, 95, 176, 156, 169, 160, 81,
         11, 245, 22, 235, 122, 117, 44, 215,
         79, 174, 213, 233, 230, 231, 173, 232,
-        116, 214, 244, 234, 168, 80, 88, 175,
-    };
+        116, 214, 244, 234, 168, 80, 88, 175
+    ];
 
 
     /// <summary>

tests/ReedSolomon.NET.Tests/GaloisTests.cs

@@ -12,7 +12,7 @@ public void Closure_Should_Never_Be_Tested()
         // Unlike the Python implementation, there is no need to test
         // for closure.  Because add(), subtract(), multiply(), and
         // divide() all return bytes, there's no way they could
-        // possible return something outside the field.
+        // possibly return something outside the field.
     }
 
     [Fact]

tests/ReedSolomon.NET.Tests/MatrixTests.cs

@@ -17,31 +17,27 @@ public void ToOneLineString_Should_Return_The_Right_String() =>
     [Fact]
     public void Multiply_Two_Matrices_Should_Return_The_Right_Matrix()
     {
-        var m1 = new Matrix(new[]
-        {
-            new byte []{ 1, 2 },
-            new byte []{ 3, 4 }
-        });
+        var m1 = new Matrix([
+            [1, 2],
+            [3, 4]
+        ]);
 
-        var m2 = new Matrix(new[]
-        {
-            new byte []{ 5, 6 },
-            new byte []{ 7, 8 }
-        });
+        var m2 = new Matrix([
+            [5, 6],
+            [7, 8]
+        ]);
         var result = m1.Multiply(m2);
         result.ToString().ShouldBe("[11, 22]\n[19, 42]\n");
     }
 
     [Fact]
     public void Inverse_Matrix_Should_Return_The_Right_Matrix()
     {
-        Matrix m = new (
-            new[]
-            {
-                new byte [] { 56, 23, 98 },
-                new byte [] { 3, 100, 200 },
-                new byte [] { 45, 201, 123 }
-            });
+        Matrix m = new ([
+            [56, 23, 98],
+            [3, 100, 200],
+            [45, 201, 123]
+        ]);
         m.Invert().ToString().ShouldBe("[175, 133, 33]\n[130, 13, 245]\n[112, 35, 126]\n");
         Matrix.Identity(3).ShouldBe(m.Multiply(m.Invert()));
     }

tests/ReedSolomon.NET.Tests/ReedSolomonTests.cs

@@ -16,11 +16,11 @@ public void OneEncode_Parity_Should_Be_Correct()
         {
             var codec = new ReedSolomon(5, 5, codingLoop);
             var shards = new byte[10][];
-            shards[0] = new byte[] {0, 1};
-            shards[1] = new byte[] {4, 5};
-            shards[2] = new byte[] {2, 3};
-            shards[3] = new byte[] {6, 7};
-            shards[4] = new byte[] {8, 9};
+            shards[0] = [0, 1];
+            shards[1] = [4, 5];
+            shards[2] = [2, 3];
+            shards[3] = [6, 7];
+            shards[4] = [8, 9];
             shards[5] = new byte[2];
             shards[6] = new byte[2];
             shards[7] = new byte[2];
@@ -29,11 +29,11 @@ public void OneEncode_Parity_Should_Be_Correct()
 
             codec.EncodeParity(shards, 0, 2);
 
-            shards[5].ShouldBe(new byte[] {12, 13});
-            shards[6].ShouldBe(new byte[] {10, 11});
-            shards[7].ShouldBe(new byte[] {14, 15});
-            shards[8].ShouldBe(new byte[] {90, 91});
-            shards[9].ShouldBe(new byte[] {94, 95});
+            shards[5].ShouldBe([12, 13]);
+            shards[6].ShouldBe([10, 11]);
+            shards[7].ShouldBe([14, 15]);
+            shards[8].ShouldBe([90, 91]);
+            shards[9].ShouldBe([94, 95]);
 
             codec.IsParityCorrect(shards, 0, 2).ShouldBeTrue();
             shards[8][0] += 1;
@@ -76,7 +76,7 @@ public void BigEncodeDecode()
     }
 
     /**
-     * Encodes a set of data shards, and then tries decoding
+     * Encodes a set of data shards and then tries decoding
      * using all possible subsets of the encoded shards.
      *
      * Uses 5+5 coding, so there must be 5 input data shards.
@@ -258,13 +258,13 @@ private static List<int[]> AllSubsets(int n, int min, int max)
         var result = new List<int[]>();
         if (n == 0)
         {
-            result.Add(Array.Empty<int>());
+            result.Add([]);
         }
         else
         {
             for (var i = min; i < max - n; i++)
             {
-                int[] prefix = {i};
+                int[] prefix = [i];
                 result.AddRange(AllSubsets(n - 1, i + 1, max)
                     .Select(suffix => AppendIntArrays(prefix, suffix)));
             }