Remove the Element Call Picture in Picture feature flag. (#3204)

pixlwave · web-flow · commit 61df1dd18cfd · 2024-08-27T11:07:19.000+01:00
diff --git a/ElementX/Sources/Application/AppCoordinator.swift b/ElementX/Sources/Application/AppCoordinator.swift
@@ -659,7 +659,7 @@ class AppCoordinator: AppCoordinatorProtocol, AuthenticationFlowCoordinatorDeleg
         
         let callScreenCoordinator = CallScreenCoordinator(parameters: .init(elementCallService: elementCallService,
                                                                             configuration: configuration,
-                                                                            elementCallPictureInPictureEnabled: false,
+                                                                            allowPictureInPicture: false,
                                                                             appHooks: appHooks))
         
         callScreenCoordinator.actions
diff --git a/ElementX/Sources/Application/AppSettings.swift b/ElementX/Sources/Application/AppSettings.swift
@@ -47,7 +47,6 @@ final class AppSettings {
         case publicSearchEnabled
         case fuzzyRoomListSearchEnabled
         case pinningEnabled
-        case elementCallPictureInPictureEnabled
     }
     
     private static var suiteName: String = InfoPlistReader.main.appGroupIdentifier
@@ -285,9 +284,6 @@ final class AppSettings {
     
     @UserPreference(key: UserDefaultsKeys.pinningEnabled, defaultValue: false, storageType: .userDefaults(store))
     var pinningEnabled
-    
-    @UserPreference(key: UserDefaultsKeys.elementCallPictureInPictureEnabled, defaultValue: false, storageType: .userDefaults(store))
-    var elementCallPictureInPictureEnabled
         
     #endif
     
diff --git a/ElementX/Sources/FlowCoordinators/UserSessionFlowCoordinator.swift b/ElementX/Sources/FlowCoordinators/UserSessionFlowCoordinator.swift
@@ -589,7 +589,7 @@ class UserSessionFlowCoordinator: FlowCoordinatorProtocol {
         
         let callScreenCoordinator = CallScreenCoordinator(parameters: .init(elementCallService: elementCallService,
                                                                             configuration: configuration,
-                                                                            elementCallPictureInPictureEnabled: appSettings.elementCallPictureInPictureEnabled,
+                                                                            allowPictureInPicture: true,
                                                                             appHooks: appHooks))
         
         callScreenCoordinator.actions
diff --git a/ElementX/Sources/Screens/CallScreen/CallScreenCoordinator.swift b/ElementX/Sources/Screens/CallScreen/CallScreenCoordinator.swift
@@ -21,7 +21,7 @@ import SwiftUI
 struct CallScreenCoordinatorParameters {
     let elementCallService: ElementCallServiceProtocol
     let configuration: ElementCallConfiguration
-    let elementCallPictureInPictureEnabled: Bool
+    let allowPictureInPicture: Bool
     let appHooks: AppHooks
 }
 
@@ -46,7 +46,7 @@ final class CallScreenCoordinator: CoordinatorProtocol {
     init(parameters: CallScreenCoordinatorParameters) {
         viewModel = CallScreenViewModel(elementCallService: parameters.elementCallService,
                                         configuration: parameters.configuration,
-                                        elementCallPictureInPictureEnabled: parameters.elementCallPictureInPictureEnabled,
+                                        allowPictureInPicture: parameters.allowPictureInPicture,
                                         appHooks: parameters.appHooks)
     }
     
diff --git a/ElementX/Sources/Screens/CallScreen/CallScreenViewModel.swift b/ElementX/Sources/Screens/CallScreen/CallScreenViewModel.swift
@@ -24,7 +24,7 @@ typealias CallScreenViewModelType = StateStoreViewModel<CallScreenViewState, Cal
 class CallScreenViewModel: CallScreenViewModelType, CallScreenViewModelProtocol {
     private let elementCallService: ElementCallServiceProtocol
     private let configuration: ElementCallConfiguration
-    private let isPictureInPictureEnabled: Bool
+    private let isPictureInPictureAllowed: Bool
     
     private let widgetDriver: ElementCallWidgetDriverProtocol
     
@@ -43,11 +43,11 @@ class CallScreenViewModel: CallScreenViewModelType, CallScreenViewModelProtocol
     ///   - clientID: Something to identify the current client on the Element Call side
     init(elementCallService: ElementCallServiceProtocol,
          configuration: ElementCallConfiguration,
-         elementCallPictureInPictureEnabled: Bool,
+         allowPictureInPicture: Bool,
          appHooks: AppHooks) {
         self.elementCallService = elementCallService
         self.configuration = configuration
-        isPictureInPictureEnabled = elementCallPictureInPictureEnabled
+        isPictureInPictureAllowed = allowPictureInPicture
         
         switch configuration.kind {
         case .genericCallLink(let url):
@@ -189,7 +189,7 @@ class CallScreenViewModel: CallScreenViewModelType, CallScreenViewModelProtocol
     
     private func handleBackwardsNavigation() async {
         guard state.url != nil,
-              isPictureInPictureEnabled,
+              isPictureInPictureAllowed,
               let requestPictureInPictureHandler = state.bindings.requestPictureInPictureHandler else {
             actionsSubject.send(.dismiss)
             return
diff --git a/ElementX/Sources/Screens/CallScreen/View/CallScreen.swift b/ElementX/Sources/Screens/CallScreen/View/CallScreen.swift
@@ -300,7 +300,7 @@ struct CallScreen_Previews: PreviewProvider {
                                                         elementCallBaseURL: "https://call.element.io",
                                                         elementCallBaseURLOverride: nil,
                                                         colorScheme: .light),
-                                   elementCallPictureInPictureEnabled: false,
+                                   allowPictureInPicture: false,
                                    appHooks: AppHooks())
     }()
     
diff --git a/ElementX/Sources/Screens/Settings/DeveloperOptionsScreen/DeveloperOptionsScreenModels.swift b/ElementX/Sources/Screens/Settings/DeveloperOptionsScreen/DeveloperOptionsScreenModels.swift
@@ -53,7 +53,6 @@ protocol DeveloperOptionsProtocol: AnyObject {
     var elementCallBaseURLOverride: URL? { get set }
     var fuzzyRoomListSearchEnabled: Bool { get set }
     var pinningEnabled: Bool { get set }
-    var elementCallPictureInPictureEnabled: Bool { get set }
 }
 
 extension AppSettings: DeveloperOptionsProtocol { }
diff --git a/ElementX/Sources/Screens/Settings/DeveloperOptionsScreen/View/DeveloperOptionsScreen.swift b/ElementX/Sources/Screens/Settings/DeveloperOptionsScreen/View/DeveloperOptionsScreen.swift
@@ -69,11 +69,6 @@ struct DeveloperOptionsScreen: View {
                             context.elementCallBaseURLOverride = url
                         }
                     }
-                
-                Toggle(isOn: $context.elementCallPictureInPictureEnabled) {
-                    Text("Picture in Picture support")
-                    Text("Requires an Element Call deployment with support for signalling PiP availability.")
-                }
             } header: {
                 Text("Element Call")
             } footer: {

Original file line number	Diff line number	Diff line change
`@@ -53,7 +53,6 @@ protocol DeveloperOptionsProtocol: AnyObject {`
`53`	`53`	`var elementCallBaseURLOverride: URL? { get set }`
`54`	`54`	`var fuzzyRoomListSearchEnabled: Bool { get set }`
`55`	`55`	`var pinningEnabled: Bool { get set }`
`56`		`- var elementCallPictureInPictureEnabled: Bool { get set }`
`57`	`56`	`}`
`58`	`57`
`59`	`58`	`extension AppSettings: DeveloperOptionsProtocol { }`
Original file line number	Diff line number	Diff line change
`@@ -69,11 +69,6 @@ struct DeveloperOptionsScreen: View {`
`69`	`69`	`context.elementCallBaseURLOverride = url`
`70`	`70`	`}`
`71`	`71`	`}`
`72`		`-`
`73`		`- Toggle(isOn: $context.elementCallPictureInPictureEnabled) {`
`74`		`- Text("Picture in Picture support")`
`75`		`- Text("Requires an Element Call deployment with support for signalling PiP availability.")`
`76`		`- }`
`77`	`72`	`} header: {`
`78`	`73`	`Text("Element Call")`
`79`	`74`	`} footer: {`