fix: default timeout of RPC requests

Author: GeekyEggo

CHANGELOG.md

@@ -12,6 +12,12 @@
 
 # Change Log
 
+## 0.3.1
+
+### 🐞 Fix
+
+- Fix default timeout of RPC requests.
+
 ## 0.3.0
 
 ### ✨ New

src/rpc/__tests__/client.test.ts

@@ -157,14 +157,55 @@ describe("RpcClient", () => {
 		}
 	});
 
+	/**
+	 * Asserts the timeout monitor is correctly configured.
+	 */
+	describe("timeout", () => {
+		it("has a default", async () => {
+			// Arrange.
+			vi.spyOn(globalThis, "setTimeout");
+
+			// Act.
+			await client.request("test");
+			await client.request({
+				method: "test",
+				params: {
+					name: "Elgato",
+				},
+			});
+
+			// Assert.
+			expect(setTimeout).toHaveBeenCalledTimes(2);
+			expect(setTimeout).toHaveBeenNthCalledWith<Parameters<typeof setTimeout>>(1, expect.any(Function), 30000);
+			expect(setTimeout).toHaveBeenNthCalledWith<Parameters<typeof setTimeout>>(2, expect.any(Function), 30000);
+		});
+
+		it("uses specified timeout", async () => {
+			// Arrange.
+			vi.spyOn(globalThis, "setTimeout");
+
+			// Act.
+			await client.request({
+				method: "test",
+				params: {
+					name: "Elgato",
+				},
+				timeout: 1,
+			});
+
+			// Assert.
+			expect(setTimeout).toHaveBeenCalledExactlyOnceWith<Parameters<typeof setTimeout>>(expect.any(Function), 1);
+		});
+	});
+
 	/**
 	 * Asserts errors are appropriately mapped from a response.
 	 */
 	it("maps errors", async () => {
 		// Arrange, act.
 		const res = await client.request("err");
 
-		// Asserts.
+		// Assert.
 		expect(res.ok).toBe(false);
 		if (!res.ok) {
 			expect(res.error.code).toBe(1);

src/rpc/client.ts

@@ -10,6 +10,11 @@ import type { RpcSender } from "./sender.js";
  * Client capable of sending requests to, and receiving responses from, a server.
  */
 export class RpcClient {
+	/**
+	 * The timeout, in milliseconds, used when the request does not have a timeout specified; default 30 seconds.
+	 */
+	static readonly #DEFAULT_TIMEOUT = 30000;
+
 	/**
 	 * The client's options.
 	 */
@@ -163,7 +168,7 @@ export class RpcClient {
 		request: RpcRequestOptions,
 	): Promise<RpcResponse<TResult>> {
 		const id = crypto.randomUUID();
-		const { method, params, timeout } = request;
+		const { method, params, timeout = RpcClient.#DEFAULT_TIMEOUT } = request;
 
 		// Initialize the response handler.
 		const response = new Promise<RpcResponse<TResult>>((resolve) => {